[SYCL] Allow library mismatch for libdevice host object on Win32#5048
Merged
bader merged 3 commits intointel:syclfrom Dec 14, 2021
Merged
[SYCL] Allow library mismatch for libdevice host object on Win32#5048bader merged 3 commits intointel:syclfrom
bader merged 3 commits intointel:syclfrom
Conversation
VC++ yvals.h header file sets up linker directives like this: /FAILIFMISMATCH:RuntimeLibrary=MT_StaticRelease This will break linking, if the final standard libraries linked to the program have different configuration. Since the host part of libdevice objects is empty, we do not care about the mismatch checking. Signed-off-by: jinge90 <ge.jin@intel.com>
vzakhari
suggested changes
Nov 30, 2021
Contributor
Author
|
/summary |
Contributor
Author
|
/summary:run |
Signed-off-by: jinge90 <ge.jin@intel.com>
Contributor
Author
|
Hi, @vzakhari |
vzakhari
approved these changes
Dec 14, 2021
Contributor
vzakhari
left a comment
vzakhari
left a comment
There was a problem hiding this comment.
Hi Ge, I am very sorry for such a huge delay. I am not sure how it went under the radar.
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Dec 14, 2021
* sycl: [CI] Refactor workflow files (intel#5134) [CI] Enable HIP and CUDA plugins in GitHub Actions builds (intel#5087) [SYCL] Implement queue flushing (intel#5052) [SYCL] Allow library mismatch for libdevice host object on Win32 (intel#5048) [SYCL] Remove unnecessary template parameter (intel#5127) [CI] Use clang-format from nightly builds (intel#5126)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VC++ yvals.h header file sets up linker directives like this:
/FAILIFMISMATCH:RuntimeLibrary=MT_StaticRelease
This will break linking, if the final standard libraries linked
to the program have different configuration. Since the host part
of libdevice objects is empty, we do not care about the mismatch
checking.
Signed-off-by: jinge90 ge.jin@intel.com