[SYCL] Use teams to assign code ownership#5016
Conversation
vladimirlaz
changed the title
|
@vladimirlaz, please, use a private fork to open a pull request. |
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
AlexeySotkin
left a comment
AlexeySotkin
left a comment
There was a problem hiding this comment.
SPIR-V part looks good to me.
|
@vladimirlaz, ping. |
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
LGTM, a couple of suggestions, which hopefully are okay.
|
@vladimirlaz, is there an infrastructure team we can assign as a code owner for .github script sources? |
|
@vladimirlaz, please, resolve merge conflicts. |
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
Please, fix pre-commit checks.
| sycl/source/detail/posix_pi.cpp @smaslov-intel | ||
| sycl/source/detail/windows_pi.cpp @smaslov-intel | ||
| # Level Zero plugin | ||
| sycl/sycl/plugins/level_zero @intel/dpcpp-l0-pi-reviewers |
There was a problem hiding this comment.
@vladimirlaz, code review assignment is broken.
I think it's due to bugs in the .github/CODEOWNERS file.
sycl/sycl/plugins/level_zero -> sycl/plugins/level_zero?
| # Driver | ||
| clang/**/Driver @mdtoguchi @AGindinson @hchilama | ||
| # Clang driver | ||
| clang/**/Driver @intel/dpcpp-clang-driver-reviewers |
There was a problem hiding this comment.
Please, make sure that all these teams exist and have write access to the repository.
I can't assign intel/dpcpp-clang-driver-reviewers as #5239 reviewer.
There was a problem hiding this comment.
Good catch. Fixed for all teams both in intel/llvm and intel/llvm-test-suite.
There was a problem hiding this comment.
Okay. Please, test automatic assignment. I think it's still broken due to the issue in my previous comment.
There was a problem hiding this comment.
it worked on change of the sources in the PR (fixed 2 hours form now). No automatic assignemnt for existent PR.
5 participants
No description provided.