[ESIMD] Disable non-critical messages from VC backend (disable-finalizer-msg) #4918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The E2E test for this patch is: intel/llvm-test-suite#557 |
v-klochkov
force-pushed
the
esimd_non_critical_messages
branch
from
9e20b63 to
bb20d63
Compare
romanovvlad
reviewed
Nov 9, 2021
kbobrovs
previously approved these changes
Nov 9, 2021
Contributor
Author
|
/verify with intel/llvm-test-suite#557 |
kbobrovs
previously approved these changes
Nov 16, 2021
v-klochkov
dismissed stale reviews from s-kanaev, pvchupin, and kbobrovs
via
ee7fe3e
Contributor
|
@v-klochkov, please, fix pre-commit failures. |
Contributor
Author
The tests fail because the GPU driver in CI is very old (21636 on Linux). It fails with "-disable-finalizer-msg" is not recognized switch/option. |
kbobrovs
reviewed
Jan 11, 2022
kbobrovs
previously approved these changes
Jan 12, 2022
Contributor
|
/verify with intel/llvm-test-suite#557 |
bader
previously approved these changes
Jan 12, 2022
v-klochkov
changed the title
Contributor
Author
|
/verify with intel/llvm-test-suite#557 |
kbobrovs
previously approved these changes
Feb 28, 2022
Contributor
Author
|
/verify with intel/llvm-test-suite#557 |
1 similar comment
Contributor
Author
|
/verify with intel/llvm-test-suite#557 |
kbobrovs
previously approved these changes
Mar 3, 2022
romanovvlad
previously approved these changes
Mar 3, 2022
…zer-msg) 1. Add doc for the existing environment variable SYCL_RT_WARNING_LEVEL. 2. Add -disable-finalizer-msg to vc-codegen to disable warnings/hints from vc-codegen about spilling some registers to memory, which are performance hints and often not wanted in std output by default. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
esimd_non_critical_messages
branch
from
edb3e64 to
c1ac7dc
Compare
Contributor
Author
|
Force-pushed the changes to avoid the mess in the commits (217 were accumulated) and to re-start the testing. |
kbobrovs
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable is expected to set to 0 or a positive number.
The bigger the value/level the more warnings and hints the RT may emit.
This patch adds -disable-finalizer-msg to vc-codegen to disable
warnings/hints from vc-codegen about spilling some registers to memory,
which are performance hints and often not wanted in std output by default.
Signed-off-by: Vyacheslav N Klochkov [email protected]