[SYCL] Add support for bfloat16 conversion #4213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlychkov
reviewed
Aug 2, 2021
Contributor
Author
|
The spec draft is available at #4237 |
MrSidims
added a commit
to MrSidims/llvm-test-suite
that referenced
this pull request
Aug 3, 2021
Spec: intel/llvm#4237 Implementation: intel/llvm#4213 Signed-off-by: Dmitry Sidorov <[email protected]>
AlexeySotkin
force-pushed
the
bfloat16_conversion
branch
from
dc84b26 to
5f70d02
Compare
mlychkov
reviewed
Aug 6, 2021
AlexeySotkin
force-pushed
the
bfloat16_conversion
branch
from
5f70d02 to
486ec26
Compare
vladimirlaz
reviewed
Aug 9, 2021
mlychkov
previously approved these changes
Aug 11, 2021
MrSidims
approved these changes
Aug 12, 2021
Contributor
|
E2E test: intel/llvm-test-suite#390 |
MrSidims
requested changes
Aug 12, 2021
MrSidims
reviewed
Aug 20, 2021
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
Overall LGTM. Please replace [WIP] with [SYCL]
Signed-off-by: Alexey Sotkin <[email protected]>
- Apply clang-format.patch - Remove non-const members - Add default constructors and destructor - Add [[sycl_detail::uses_aspects(ext_intel_bf16_conversion)]] attribute to the class declaration Signed-off-by: Alexey Sotkin <[email protected]>
Signed-off-by: Alexey Sotkin <[email protected]>
Signed-off-by: Alexey Sotkin <[email protected]>
Also fixing coding style in the test. Signed-off-by: Alexey Sotkin <[email protected]>
Co-authored-by: Dmitry Sidorov <[email protected]>
Adding quotes to the exception message. Co-authored-by: Dmitry Sidorov <[email protected]>
Also reorder member functions and improve the test. Signed-off-by: Alexey Sotkin <[email protected]>
Signed-off-by: Alexey Sotkin <[email protected]>
Signed-off-by: Alexey Sotkin <[email protected]>
AlexeySotkin
force-pushed
the
bfloat16_conversion
branch
from
4e9ef28 to
be8a7e7
Compare
Contributor
Author
I think we can replace it during squash. |
Contributor
But would @bader notice such commit in a query to merge? |
AlexeySotkin
changed the title
Contributor
Author
I have updated the PR title |
vladimirlaz
approved these changes
Aug 26, 2021
mlychkov
approved these changes
Aug 26, 2021
bader
reviewed
Aug 26, 2021
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Sep 1, 2021
Spec: intel/llvm#4237 Implementation: intel/llvm#4213 Signed-off-by: Dmitry Sidorov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Spec: intel#4237 Implementation: intel#4213 Signed-off-by: Dmitry Sidorov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexey Sotkin [email protected]