[SYCL][NFC] Refactor RT unit tests #4021
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| //==---- DefaultValues.cpp --- Spec constants default values unit test -----==// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #define SYCL2020_DISABLE_DEPRECATION_WARNINGS | ||
|
|
||
| #include <CL/sycl.hpp> | ||
|
|
||
| #include <helpers/CommonRedefinitions.hpp> | ||
| #include <helpers/PiImage.hpp> | ||
| #include <helpers/PiMock.hpp> | ||
|
|
||
| #include <gtest/gtest.h> | ||
|
|
||
| class TestKernel; | ||
| const static sycl::specialization_id<int> SpecConst1{42}; | ||
|
|
||
| __SYCL_INLINE_NAMESPACE(cl) { | ||
| namespace sycl { | ||
| namespace detail { | ||
| template <> struct KernelInfo<TestKernel> { | ||
| static constexpr unsigned getNumParams() { return 0; } | ||
| static const kernel_param_desc_t &getParamDesc(int) { | ||
| static kernel_param_desc_t Dummy; | ||
| return Dummy; | ||
| } | ||
| static constexpr const char *getName() { return "TestKernel"; } | ||
| static constexpr bool isESIMD() { return false; } | ||
| static constexpr bool callsThisItem() { return false; } | ||
| static constexpr bool callsAnyThisFreeFunction() { return false; } | ||
| }; | ||
|
|
||
| template <> const char *get_spec_constant_symbolic_ID<SpecConst1>() { | ||
| return "SC1"; | ||
| } | ||
| } // namespace detail | ||
| } // namespace sycl | ||
| } // __SYCL_INLINE_NAMESPACE(cl) | ||
|
|
||
| int SpecConstVal0 = 0; | ||
| int SpecConstVal1 = 0; | ||
|
|
||
| static pi_result | ||
| redefinedProgramSetSpecializationConstant(pi_program prog, pi_uint32 spec_id, | ||
| size_t spec_size, | ||
| const void *spec_value) { | ||
| if (spec_id == 0) | ||
| SpecConstVal0 = *static_cast<const int *>(spec_value); | ||
| if (spec_id == 1) | ||
| SpecConstVal1 = *static_cast<const int *>(spec_value); | ||
|
|
||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| static sycl::unittest::PiImage generateImageWithSpecConsts() { | ||
| using namespace sycl::unittest; | ||
|
|
||
| std::vector<char> SpecConstData; | ||
| PiProperty SC1 = makeSpecConstant<int>(SpecConstData, "SC1", {0}, {0}, {42}); | ||
| PiProperty SC2 = makeSpecConstant<int>(SpecConstData, "SC2", {1}, {0}, {8}); | ||
|
|
||
| PiPropertySet PropSet; | ||
| addSpecConstants({SC1, SC2}, std::move(SpecConstData), PropSet); | ||
|
|
||
| std::vector<unsigned char> Bin{0, 1, 2, 3, 4, 5}; // Random data | ||
|
|
||
| PiArray<PiOffloadEntry> Entries = makeEmptyKernels({"TestKernel"}); | ||
|
|
||
| PiImage Img{PI_DEVICE_BINARY_TYPE_SPIRV, // Format | ||
| __SYCL_PI_DEVICE_BINARY_TARGET_SPIRV64, // DeviceTargetSpec | ||
| "", // Compile options | ||
| "", // Link options | ||
| std::move(Bin), | ||
| std::move(Entries), | ||
| std::move(PropSet)}; | ||
|
|
||
| return Img; | ||
| } | ||
|
|
||
| sycl::unittest::PiImage Img = generateImageWithSpecConsts(); | ||
| sycl::unittest::PiImageArray ImgArray{Img}; | ||
|
|
||
| TEST(SpecConstDefaultValues, DISABLED_DefaultValuesAreSet) { | ||
| sycl::platform Plt{sycl::default_selector()}; | ||
| if (Plt.is_host()) { | ||
| std::cerr << "Test is not supported on host, skipping\n"; | ||
| return; // test is not supported on host. | ||
| } | ||
|
|
||
| if (Plt.get_backend() == sycl::backend::cuda) { | ||
| std::cerr << "Test is not supported on CUDA platform, skipping\n"; | ||
| return; | ||
| } | ||
|
|
||
| sycl::unittest::PiMock Mock{Plt}; | ||
| setupDefaultMockAPIs(Mock); | ||
| Mock.redefine<sycl::detail::PiApiKind::piextProgramSetSpecializationConstant>( | ||
| redefinedProgramSetSpecializationConstant); | ||
|
|
||
| const sycl::device Dev = Plt.get_devices()[0]; | ||
|
|
||
| sycl::queue Queue{Dev}; | ||
|
|
||
| const sycl::context Ctx = Queue.get_context(); | ||
|
|
||
| sycl::kernel_bundle KernelBundle = | ||
| sycl::get_kernel_bundle<sycl::bundle_state::input>(Ctx, {Dev}); | ||
| auto ExecBundle = sycl::build(KernelBundle); | ||
| Queue.submit([&](sycl::handler &CGH) { | ||
| CGH.use_kernel_bundle(ExecBundle); | ||
| CGH.single_task<TestKernel>([] {}); // Actual kernel does not matter | ||
| }); | ||
|
|
||
| EXPECT_EQ(SpecConstVal0, 42); | ||
| EXPECT_EQ(SpecConstVal1, 8); | ||
| } | ||
|
|
||
| TEST(SpecConstDefaultValues, DISABLED_DefaultValuesAreOverriden) { | ||
| sycl::platform Plt{sycl::default_selector()}; | ||
| if (Plt.is_host()) { | ||
| std::cerr << "Test is not supported on host, skipping\n"; | ||
| return; // test is not supported on host. | ||
| } | ||
|
|
||
| if (Plt.get_backend() == sycl::backend::cuda) { | ||
| std::cerr << "Test is not supported on CUDA platform, skipping\n"; | ||
| return; | ||
| } | ||
|
|
||
| sycl::unittest::PiMock Mock{Plt}; | ||
| setupDefaultMockAPIs(Mock); | ||
| Mock.redefine<sycl::detail::PiApiKind::piextProgramSetSpecializationConstant>( | ||
| redefinedProgramSetSpecializationConstant); | ||
|
|
||
| const sycl::device Dev = Plt.get_devices()[0]; | ||
|
|
||
| sycl::queue Queue{Dev}; | ||
|
|
||
| const sycl::context Ctx = Queue.get_context(); | ||
|
|
||
| sycl::kernel_bundle KernelBundle = | ||
| sycl::get_kernel_bundle<sycl::bundle_state::input>(Ctx, {Dev}); | ||
| KernelBundle.set_specialization_constant<SpecConst1>(80); | ||
| auto ExecBundle = sycl::build(KernelBundle); | ||
| Queue.submit([&](sycl::handler &CGH) { | ||
| CGH.use_kernel_bundle(ExecBundle); | ||
| CGH.single_task<TestKernel>([] {}); // Actual kernel does not matter | ||
| }); | ||
|
|
||
| EXPECT_EQ(SpecConstVal0, 80); | ||
| EXPECT_EQ(SpecConstVal1, 8); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| //==---- CommonRedefinitions.hpp --- Header with common PI redefinitions ---==// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include <CL/sycl.hpp> | ||
| #include <helpers/PiImage.hpp> | ||
| #include <helpers/PiMock.hpp> | ||
|
|
||
| inline pi_result redefinedProgramCreateCommon(pi_context, const void *, size_t, | ||
| pi_program *) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
|
Comment on lines
+13
to
+17
Contributor
There was a problem hiding this comment. Nit. I would allocate something like |
||
| inline pi_result redefinedProgramBuildCommon( | ||
| pi_program prog, pi_uint32, const pi_device *, const char *, | ||
| void (*pfn_notify)(pi_program program, void *user_data), void *user_data) { | ||
| if (pfn_notify) { | ||
| pfn_notify(prog, user_data); | ||
| } | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedProgramCompileCommon( | ||
| pi_program, pi_uint32, const pi_device *, const char *, pi_uint32, | ||
| const pi_program *, const char **, void (*)(pi_program, void *), void *) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedProgramLinkCommon(pi_context, pi_uint32, | ||
| const pi_device *, const char *, | ||
| pi_uint32, const pi_program *, | ||
| void (*)(pi_program, void *), | ||
| void *, pi_program *) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedProgramGetInfoCommon(pi_program program, | ||
| pi_program_info param_name, | ||
| size_t param_value_size, | ||
| void *param_value, | ||
| size_t *param_value_size_ret) { | ||
| if (param_name == PI_PROGRAM_INFO_NUM_DEVICES) { | ||
| auto value = reinterpret_cast<unsigned int *>(param_value); | ||
| *value = 1; | ||
| } | ||
|
|
||
| if (param_name == PI_PROGRAM_INFO_BINARY_SIZES) { | ||
| auto value = reinterpret_cast<size_t *>(param_value); | ||
| value[0] = 1; | ||
| } | ||
|
|
||
| if (param_name == PI_PROGRAM_INFO_BINARIES) { | ||
| auto value = reinterpret_cast<unsigned char *>(param_value); | ||
| value[0] = 1; | ||
| } | ||
|
|
||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedProgramRetainCommon(pi_program program) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedProgramReleaseCommon(pi_program program) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedKernelCreateCommon(pi_program program, | ||
| const char *kernel_name, | ||
| pi_kernel *ret_kernel) { | ||
| *ret_kernel = reinterpret_cast<pi_kernel>(new int[1]); | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedKernelRetainCommon(pi_kernel kernel) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedKernelReleaseCommon(pi_kernel kernel) { | ||
| delete[] reinterpret_cast<int *>(kernel); | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedKernelGetInfoCommon(pi_kernel kernel, | ||
| pi_kernel_info param_name, | ||
| size_t param_value_size, | ||
| void *param_value, | ||
| size_t *param_value_size_ret) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedKernelSetExecInfoCommon( | ||
| pi_kernel kernel, pi_kernel_exec_info value_name, size_t param_value_size, | ||
| const void *param_value) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedEventsWaitCommon(pi_uint32 num_events, | ||
| const pi_event *event_list) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedEventReleaseCommon(pi_event event) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline pi_result redefinedEnqueueKernelLaunchCommon( | ||
| pi_queue, pi_kernel, pi_uint32, const size_t *, const size_t *, | ||
| const size_t *, pi_uint32, const pi_event *, pi_event *) { | ||
| return PI_SUCCESS; | ||
| } | ||
|
|
||
| inline void setupDefaultMockAPIs(sycl::unittest::PiMock &Mock) { | ||
| using namespace sycl::detail; | ||
| Mock.redefine<PiApiKind::piProgramCreate>(redefinedProgramCreateCommon); | ||
| Mock.redefine<PiApiKind::piProgramCompile>(redefinedProgramCompileCommon); | ||
| Mock.redefine<PiApiKind::piProgramLink>(redefinedProgramLinkCommon); | ||
| Mock.redefine<PiApiKind::piProgramBuild>(redefinedProgramBuildCommon); | ||
| Mock.redefine<PiApiKind::piProgramGetInfo>(redefinedProgramGetInfoCommon); | ||
| Mock.redefine<PiApiKind::piProgramRetain>(redefinedProgramRetainCommon); | ||
| Mock.redefine<PiApiKind::piProgramRelease>(redefinedProgramReleaseCommon); | ||
| Mock.redefine<PiApiKind::piKernelCreate>(redefinedKernelCreateCommon); | ||
| Mock.redefine<PiApiKind::piKernelRetain>(redefinedKernelRetainCommon); | ||
| Mock.redefine<PiApiKind::piKernelRelease>(redefinedKernelReleaseCommon); | ||
| Mock.redefine<PiApiKind::piKernelGetInfo>(redefinedKernelGetInfoCommon); | ||
| Mock.redefine<PiApiKind::piKernelSetExecInfo>( | ||
| redefinedKernelSetExecInfoCommon); | ||
| Mock.redefine<PiApiKind::piEventsWait>(redefinedEventsWaitCommon); | ||
| Mock.redefine<PiApiKind::piEventRelease>(redefinedEventReleaseCommon); | ||
| Mock.redefine<PiApiKind::piEnqueueKernelLaunch>( | ||
| redefinedEnqueueKernelLaunchCommon); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.