Skip to content

[SYCL] Allow kernel names in anonymous namespace #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladimirlaz merged 5 commits into from
May 6, 2021
Merged

[SYCL] Allow kernel names in anonymous namespace #3649

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98a1d7d
[SYCL] Allow kernel names in anonymous namespace
srividya-sundaram Apr 28, 2021
d75185f
update test
srividya-sundaram Apr 28, 2021
4b26c05
Update int_header1.cpp test
srividya-sundaram Apr 29, 2021
c197614
Add check-next to int_header1.cpp
srividya-sundaram Apr 30, 2021
705af36
Update test with nested anon ns cases
srividya-sundaram May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions clang/test/CodeGenSYCL/int_header1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
// RUN: %clang_cc1 -fsycl-is-device -internal-isystem %S/Inputs -sycl-std=2020 -fsycl-int-header=%t.h %s -o %t.out
// RUN: FileCheck -input-file=%t.h %s

// Check if forward declarations of kernel names in anonymous namespace are in
// anonymous namespace in the integration header as well.
// CHECK:namespace {
// CHECK:class ClassInAnonNS;
// CHECK:}

// CHECK:template <> struct KernelInfo<class KernelName> {
// CHECK:template <> struct KernelInfo<::nm1::nm2::KernelName0> {
// CHECK:template <> struct KernelInfo<::nm1::KernelName1> {
Expand Down Expand Up @@ -119,6 +125,10 @@ struct MyWrapper {
kernel_single_task<TmplClassInAnonNS<class ClassInAnonNS>>(
[=]() { acc.use(); });

// kernel name type is a class, declared in the anonymous namespace
kernel_single_task<ClassInAnonNS>(
[=]() { acc.use(); });

// Kernel name type is a templated specialization class with empty template pack argument
kernel_single_task<nm1::KernelName9<char>>(
[=]() { acc.use(); });
Expand Down