Skip to content

[SYCL] Fixed an issue building shared-libs config #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 1 commit into from
Mar 5, 2021
Merged

[SYCL] Fixed an issue building shared-libs config #3301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/lib/CodeGen/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,6 @@ add_clang_library(clangCodeGen
clangBasic
clangFrontend
clangLex
clangSema
clangSerialization
)
1 change: 1 addition & 0 deletions clang/lib/Frontend/Rewrite/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ add_clang_library(clangRewriteFrontend
clangFrontend
clangLex
clangRewrite
clangSema
clangSerialization

DEPENDS
Expand Down
1 change: 1 addition & 0 deletions clang/lib/Index/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ add_clang_library(clangIndex
clangFrontend
clangLex
clangRewrite
clangSema
clangSerialization
clangToolingCore

Expand Down
1 change: 1 addition & 0 deletions clang/lib/StaticAnalyzer/Frontend/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ add_clang_library(clangStaticAnalyzerFrontend
clangCrossTU
clangFrontend
clangLex
clangSema
Copy link
Contributor

@bader bader Mar 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change is needed? Is this dependency introduced by SYCL changes?

Copy link
Contributor Author

@DenisBakhvalov DenisBakhvalov Mar 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change is needed?

Some other failures were hidden by the one that I fixed with the change in llvm/lib/Passes/CMakeLists.txt. I.e. after I fixed one unresolved external problem there were 4 more.

Is this dependency introduced by SYCL changes?

Yes, I believe this failure was triggered by the recent pulldown to SYCL.
I'm not familiar with this part of FE, so I let FE people decide whether this dependency makes sense.

Copy link
Contributor

@bader bader Mar 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very suspicious. Community version doesn't have this dependency. https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CMakeLists.txt#L92
+@erichkeane, @AaronBallman, do you know the reason for clang's CodeGen to depend on Sema library?

Copy link
Contributor

@bader bader Mar 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this PR, but I'll open a separate issue to understand what's going on here.

Copy link
Contributor

@bader bader Mar 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3309.

Copy link
Contributor

@AaronBallman AaronBallman Mar 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Clang's CodeGen library relies on Sema because of: https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGDecl.cpp#L44 but I admit that this looks really suspicious to me. I could have sworn this is a layering violation (now Sema relies on CodeGen which relies on Sema). The patch that introduced the change was: llvm/llvm-project@0d61cd2 and it had all of 15 minutes of review before landing, and after landing someone pointed out the layering violation but no rollback happened. I've commented on it in community.

clangStaticAnalyzerCheckers
clangStaticAnalyzerCore

Expand Down
1 change: 1 addition & 0 deletions llvm/lib/Passes/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ add_llvm_component_library(LLVMPasses
ObjCARC
Scalar
Support
SYCLLowerIR
Target
TransformUtils
Vectorize
Expand Down