Skip to content

[SYCL]Use llvm-link's only-needed option to link device libs #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 10, 2020
Merged

[SYCL]Use llvm-link's only-needed option to link device libs #2783

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
af48e23
Use llvm-link's only-needed option to link device libs
jinge90 Nov 17, 2020
ee8a959
Fix clang-format issue
jinge90 Nov 17, 2020
668c1c7
Merge remote-tracking branch 'origin/sycl' into SyclDeviceLibsLinkOnl…
jinge90 Dec 1, 2020
702d25e
Merge remote-tracking branch 'origin/sycl' into SyclDeviceLibsLinkOnl…
jinge90 Dec 4, 2020
a3c7066
Enable libm-fp64 default link
jinge90 Dec 4, 2020
31133b6
Revert link all device libraries by default, plan to do this in a sep…
jinge90 Dec 8, 2020
cffb9fe
Fix clang-format issue
jinge90 Dec 8, 2020
ebc68a8
Fix sycl-device-lib lit failure
jinge90 Dec 8, 2020
b4bce03
Fix sycl devicelib check issue on Windows
jinge90 Dec 8, 2020
37ffa4b
Using std::find_if to replace for-loop when checking input SYCL devic…
jinge90 Dec 9, 2020
9dc7070
Fix minor defect and issues for sycl-device-lib-win
jinge90 Dec 9, 2020
865b50e
add test to check only-needed is not used when fno-sycl-device-only=all
jinge90 Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions clang/lib/Driver/ToolChains/SYCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,24 +100,24 @@ const char *SYCL::Linker::constructLLVMLinkCommand(Compilation &C,
StringRef SubArchName, StringRef OutputFilePrefix,
const InputInfoList &InputFiles) const {
ArgStringList CmdArgs;

bool LinkSYCLDeviceLibs = false;
for (const auto &II : InputFiles) {
StringRef InputFilename =
llvm::sys::path::filename(StringRef(II.getFilename()));
StringRef InputSuffix = ".o";
if (InputFilename.startswith("libsycl-") &&
InputFilename.endswith(InputSuffix)) {
LinkSYCLDeviceLibs = true;
break;
}
}
// Add the input bc's created by compile step.
// When offloading, the input file(s) could be from unbundled partially
// linked archives. The unbundled information is a list of files and not
// an actual object/archive. Take that list and pass those to the linker
// instead of the original object.
if (JA.isDeviceOffloading(Action::OFK_SYCL)) {
bool LinkSYCLDeviceLibs = false;
auto SYCLDeviceLibIter =
std::find_if(InputFiles.begin(), InputFiles.end(), [](const auto &II) {
StringRef InputFilename =
llvm::sys::path::filename(StringRef(II.getFilename()));
if (InputFilename.startswith("libsycl-") &&
InputFilename.endswith(".o"))
return true;
else
return false;
});
LinkSYCLDeviceLibs = (SYCLDeviceLibIter != InputFiles.end());
// Go through the Inputs to the link. When a listfile is encountered, we
// know it is an unbundled generated list.
if (LinkSYCLDeviceLibs)
Expand Down