Skip to content

[SYCL][ESIMD] Preserve undef initializer for globals in ESIMDLowerVecArg pass #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2020
Merged

[SYCL][ESIMD] Preserve undef initializer for globals in ESIMDLowerVecArg pass #2555

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af13cc6
[SYCL][ESIMD] Precommit test for ESIMDLowerVecArg pass
DenisBakhvalov Sep 28, 2020
b63292d
[SYCL][ESIMD] Preserving undef intializer for globals in ESIMDLowerVe…
DenisBakhvalov Sep 28, 2020
ee814a9
Addressed comments
DenisBakhvalov Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions llvm/lib/SYCLLowerIR/LowerESIMDVecArg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,13 @@ void ESIMDLowerVecArgPass::fixGlobals(Module &M) {
if (NewTy && !G.user_empty()) {
// Peel off ptr type that getSimdArgPtrTyOrNull applies
NewTy = NewTy->getPointerElementType();
auto ZeroInit = ConstantAggregateZero::get(NewTy);
auto InitVal =
G.hasInitializer() && isa<UndefValue>(G.getInitializer())
? static_cast<ConstantData *>(UndefValue::get(NewTy))
: static_cast<ConstantData *>(ConstantAggregateZero::get(NewTy));
auto NewGlobalVar =
new GlobalVariable(NewTy, G.isConstant(), G.getLinkage(), ZeroInit,
"", G.getThreadLocalMode(), G.getAddressSpace());
new GlobalVariable(NewTy, G.isConstant(), G.getLinkage(), InitVal, "",
G.getThreadLocalMode(), G.getAddressSpace());
NewGlobalVar->setExternallyInitialized(G.isExternallyInitialized());
NewGlobalVar->copyAttributesFrom(&G);
NewGlobalVar->takeName(&G);
Expand Down
19 changes: 19 additions & 0 deletions llvm/test/SYCLLowerIR/esimd_global_undef.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -ESIMDLowerVecArg -S | FileCheck %s

target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
target triple = "spir64-unknown-unknown-sycldevice"

%"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd" = type { <2512 x i32> }

; CHECK: @GlobalGRF_data = dso_local global <2512 x i32> undef, align 16384
@GlobalGRF_data = dso_local global %"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd" undef, align 16384

define void @f(<2512 x i32> %simd_val) {
; CHECK-LABEL: @f(
; CHECK-NEXT: store <2512 x i32> [[SIMD_VAL:%.*]], <2512 x i32> addrspace(4)* getelementptr (%"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd", %"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd" addrspace(4)* addrspacecast (%"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd"* bitcast (<2512 x i32>* @GlobalGRF_data to %"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd"*) to %"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd" addrspace(4)*), i64 0, i32 0), align 16384
; CHECK-NEXT: ret void
;
store <2512 x i32> %simd_val, <2512 x i32> addrspace(4)* getelementptr (%"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd", %"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd" addrspace(4)* addrspacecast (%"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd"* @GlobalGRF_data to %"class._ZTSN2cl4sycl5INTEL3gpu4simdIiLi2512EEE.cl::sycl::INTEL::gpu::simd" addrspace(4)*), i64 0, i32 0), align 16384
ret void
}