[SYCL] Release PI queue on queue_impl destruction #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYCL 1.2.1 specification requires queue to either encapsulate an OpenCL interop object or be a host queue. The DPC++ implementation, however, allows for different backends. Change queue_impl destructor to release whatever native handle there is.
romanovvlad
approved these changes
Jul 14, 2020
jsji
pushed a commit
that referenced
this pull request
Aug 11, 2023
…atches (#2108) Removes use of setOpaquePointer --> Can be removed without any side effect. isOpaqueOrPointeeTypeMatches --> is always true. Thanks Signed-off-by: Arvind Sudarsanam <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@42d7c59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL 1.2.1 specification requires queue to either encapsulate an
OpenCL interop object or be a host queue. The DPC++ implementation,
however, allows for different backends. Change queue_impl destructor to
release whatever native handle there is.