Add CPU counter benchmark #20978
Merged
Add CPU counter benchmark #20978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luszczewskakasia1
force-pushed
the
count-bench
branch
10 times, most recently
from
8901898 to
ccad86b
Compare
PatKamin
reviewed
Dec 31, 2025
| ret.append(f"{k} {v}") | ||
| ret.sort() | ||
| return self._bench_name + " " + ", ".join(ret) | ||
| return self._bench_name + " " + ", ".join(ret) + self._cpu_count_str() |
Contributor
There was a problem hiding this comment.
explicit_group and display_name have to include this string as well.
Contributor
|
Drafted until cpu count support is merged in Compute Benchmarks repo |
luszczewskakasia1
force-pushed
the
count-bench
branch
5 times, most recently
from
fc5fea3 to
2f93b79
Compare
Contributor
|
change in Compute Benchmarks already merged, you may continue work here now |
luszczewskakasia1
force-pushed
the
count-bench
branch
2 times, most recently
from
4ff2365 to
1002bfb
Compare
PatKamin
approved these changes
Jan 12, 2026
| nAppendCopy=0, | ||
| ), | ||
| ] | ||
|
|
Contributor
There was a problem hiding this comment.
you have to bump Compute Benchmark's version (to this commit: intel/compute-benchmarks@667721a);
Also, how is it working without bumping the version? I would expect our tests to fail in CI...
Contributor
|
@intel/llvm-gatekeepers please consider merging |
luszczewskakasia1
force-pushed
the
count-bench
branch
2 times, most recently
from
9aac409 to
772cb99
Compare
lukaszstolarczuk
approved these changes
Jan 12, 2026
Signed-off-by: luszczewskakasia1 <[email protected]>
Contributor
|
@intel/llvm-gatekeepers , please merge - these are benchmarks only change, already reviewed |
lukaszstolarczuk
added a commit
to lukaszstolarczuk/llvm
that referenced
this pull request
Jan 13, 2026
- Fix missing param passing to torch benchmark bin (ref. intel#20978) - Extend test case to check if the param is passed, as expected - Move log with full command to execute from Debug to Info
sarnex
pushed a commit
that referenced
this pull request
Jan 14, 2026
- Fix missing param passing to torch benchmark bin (ref. #20978) - Extend test case to check if the param is passed, as expected - Move log with full command to execute from Debug to Info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.