Skip to content

[SYCL[E2E] Enable Basic/image tests #20959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KornevNikita merged 3 commits into from
Jan 29, 2026
+2 −10
Merged

[SYCL[E2E] Enable Basic/image tests #20959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b578914
enable tests
mateuszpn Dec 23, 2025
a8efae5
Merge branch 'intel:sycl' into fix-bas-tests
mateuszpn Jan 5, 2026
72d791e
apply comment
mateuszpn Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions sycl/test-e2e/Basic/accessor/accessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
// RUN: %{build} -DSYCL2020_DISABLE_DEPRECATION_WARNINGS -o %t.out
// RUN: %{run} %t.out

// Test flakily fails on PVC and BMG.
// UNSUPPORTED: arch-intel_gpu_pvc || arch-intel_gpu_bmg_g21
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/16401
Copy link
Contributor

@KornevNikita KornevNikita Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify, does "We no longer support opencl:gpu" mean "we won't fix it"?

In this case, I'd say it might be better to mark this test as:

// UNSUPPORTED: opencl && (arch-intel_gpu_pvc || arch-intel_gpu_bmg_g21)
// UNSUPPORTED-INTENDED: *justification*

Just in case it's launched locally / internally.
UPD. BTW we still test PVC & opencl:gpu in pre-commit, so if it wasn't fixed, it will appear again.

Copy link
Contributor Author

@mateuszpn mateuszpn Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my mistake, I will verify the accessor test again before merge and re-consider the modification. Thanks

Copy link
Contributor Author

@mateuszpn mateuszpn Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KornevNikita I reproduced the bug on opencl:gpu as described in tracker, so fixed the test. Thanks again for being watchful.

// BMG ticket: https://github.com/intel/llvm/issues/17251
// UNSUPPORTED: opencl && (arch-intel_gpu_pvc || arch-intel_gpu_bmg_g21)
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17251

//==----------------accessor.cpp - SYCL accessor basic test ----------------==//
//
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Basic/image/image_read.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// REQUIRES: aspect-ext_intel_legacy_image
// UNSUPPORTED: linux && arch-intel_gpu_bmg_g21
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/20224
// Temporarily add explicit '-O2' to avoid GPU hang issue with O0 optimization.
// RUN: %{build} -O2 -o %t.out
// RUN: %{run} %t.out
Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Basic/image/image_sample.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// REQUIRES: aspect-ext_intel_legacy_image
// UNSUPPORTED: linux && arch-intel_gpu_bmg_g21
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/20224
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
2 changes: 0 additions & 2 deletions sycl/test-e2e/Basic/image/image_write.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// REQUIRES: aspect-ext_intel_legacy_image
// UNSUPPORTED: linux && arch-intel_gpu_bmg_g21
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/20224
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
Loading