Skip to content

[SYCL] Remove deprecated sycl device library driver options #20326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarnex merged 16 commits into from
Nov 11, 2025
Merged

[SYCL] Remove deprecated sycl device library driver options #20326

sarnex merged 16 commits into from
Nov 11, 2025

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Oct 9, 2025 •
edited
Loading

SYCL device library related driver options were marked as 'deprecated' and plans to be removed in future major release, this PR removes these driver options and clears all components dealing with these options, all related tests are updated as well.
Removing these device library related driver options is prerequisite to clear sycl device library 'online' link path in current sycl runtime and compiler which we have decided to remove to get rid of unnecessary complexity.

@jinge90 jinge90 requested a review from jopperm October 9, 2025 05:45
@jinge90
remove unused argument
e7e739e 
Signed-off-by: jinge90 <[email protected]>
@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Oct 9, 2025

I believe @vkurkov @stdale-intel @gmlueck and @xtian-github should decide if we can make this change now or not.

bader
bader reviewed Oct 9, 2025
View reviewed changes
@gmlueck
Copy link
Contributor

gmlueck commented Oct 9, 2025

I believe @vkurkov @stdale-intel @gmlueck and @xtian-github should decide if we can make this change now or not.

We just had an email conversation about a different API breaking change, and we decided that we should wait until the oneAPI "breaking change window". I assume this falls into the same category.

@gmlueck
Copy link
Contributor

gmlueck commented Oct 9, 2025

Removing these device library related driver options is prerequisite to clear sycl device library 'online' link path in current sycl runtime and compiler which we have decided to remove to get rid of unnecessary complexity.

I think I may have asked this before, but I forgot. How do we plan to handle the inclusion of "libsycl-native-bfloat16.spv" vs. "libsycl-fallback-bfloat16.spv" if we remove the onlink link capability?

@bader bader mentioned this pull request Oct 9, 2025
Merged
@jinge90 jinge90 requested a review from bader October 11, 2025 03:04
@jinge90
Copy link
Contributor Author

jinge90 commented Oct 11, 2025

Removing these device library related driver options is prerequisite to clear sycl device library 'online' link path in current sycl runtime and compiler which we have decided to remove to get rid of unnecessary complexity.

I think I may have asked this before, but I forgot. How do we plan to handle the inclusion of "libsycl-native-bfloat16.spv" vs. "libsycl-fallback-bfloat16.spv" if we remove the onlink link capability?

Hi, @gmlueck
We have discussion about this several months ago, the conclusion was relying on sycl dynamic libraries mechanism and embed required bf16 spvs into final executable. This was finished before oneAPI 2025.2 release and current bfloat16 functionality doesn't depend on devicelib 'online link' path.
I will send the original mail thread to you offline.
Thanks very much.

@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Nov 7, 2025

Hi, @aelovikov-intel and @cperkinsintel
Could you have a look to see whether we can merge this PR?

@cperkinsintel , I'll leave this one to you.

@jinge90
Copy link
Contributor Author

jinge90 commented Nov 10, 2025

Hi, @cperkinsintel
Could you take a look at this PR?
Thanks very much.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

@intel/llvm-gatekeepers please consider merging

@sarnex sarnex merged commit 16b7bcb into intel:sycl Nov 11, 2025
33 of 38 checks passed
@jinge90 jinge90 mentioned this pull request Dec 3, 2025
Merged
againull pushed a commit that referenced this pull request Dec 9, 2025
@jinge90
[SYCL] Remove devicelib jit link (#20777)
726f8d2 
The '-fsycl-device-lib-jit-link' option has been removed in
#20326. This PR cleans up
sycl-post-link and sycl runtime code to support this option. The removed
code includes:
1. Analysis in sycl-post-link tool to record which device libraries are
used by user's device image via image property
2. Program manager handling for device library require mask property to
decide which fallback spv will be loaded and linked during execution
time.
3. Program manager utils to read/load device library fallback spv files
into memory and utils to link in-memory spv device library modules with
user's module.

---------

Signed-off-by: jinge90 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bader bader bader approved these changes

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@srividya-sundaram srividya-sundaram srividya-sundaram approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jinge90 @aelovikov-intel @gmlueck @vkurkov @bader @cperkinsintel @srividya-sundaram @sarnex