-
Notifications
You must be signed in to change notification settings - Fork 794
[SYCL] Changed sycl::backend::level0 to sycl::backend::level_zero #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4dab89d
[SYCL] Changed sycl::backend::level0 to sycl::backend::level_zero
glyons-intel 9bf0ce1
Changed level0 -> level_zero.
glyons-intel eea2491
Resolving merge conflicts.
glyons-intel 91f729a
Resolving merge updates
glyons-intel e96a951
Incorporating code review comments
glyons-intel 86f4ba3
Resolving merge conflicts
glyons-intel f5083b2
Incorporating code review comments
glyons-intel df201b1
Merge remote-tracking branch 'upstream/sycl' into glyons-name
glyons-intel 4285c0d
Merge remote-tracking branch 'upstream/sycl' into glyons-name
glyons-intel 2bae103
Fixed clang-format issues
glyons-intel accad53
Resolving merge conflicts
glyons-intel bc2b9ef
Updated test files; bumped ABI version number
glyons-intel 7d2f600
Resolving merge conflicts
glyons-intel 2ab1e09
Resolved clang-format issue.
glyons-intel bceaeaf
Merge remote-tracking branch 'upstream/sycl' into glyons-name
glyons-intel c8479d3
Updated SYCL ABI version number. Addressed other code review comments.
glyons-intel 730b3f8
Merge remote-tracking branch 'upstream/sycl' into glyons-name
glyons-intel 1efcd0e
Fixed merge conflict
glyons-intel 10f75a4
Resolving merge conflicts
glyons-intel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # PI Level0 plugin library | ||
| # PI Level Zero plugin library | ||
|
|
||
| if(MSVC) | ||
| set(L0_LOADER | ||
|
|
@@ -66,44 +66,44 @@ target_include_directories(L0Loader-Headers | |
| include_directories("${sycl_inc_dir}") | ||
| include_directories(${OPENCL_INCLUDE}) | ||
|
|
||
| add_library(pi_level0 SHARED | ||
| add_library(pi_level_zero SHARED | ||
| "${sycl_inc_dir}/CL/sycl/detail/pi.h" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/pi_level0.cpp" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/pi_level0.hpp" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/pi_level_zero.cpp" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/pi_level_zero.hpp" | ||
| ) | ||
|
|
||
| if (MSVC) | ||
| # by defining __SYCL_BUILD_SYCL_DLL, we can use __declspec(dllexport) | ||
| # which are individually tagged for all pi* symbols in pi.h | ||
| target_compile_definitions(pi_level0 PRIVATE __SYCL_BUILD_SYCL_DLL) | ||
| target_compile_definitions(pi_level_zero PRIVATE __SYCL_BUILD_SYCL_DLL) | ||
| else() | ||
| # we set the visibility of all symbols 'hidden' by default. | ||
| # In pi.h file, we set exported symbols with visibility==default individually | ||
| target_compile_options(pi_level0 PUBLIC -fvisibility=hidden) | ||
| target_compile_options(pi_level_zero PUBLIC -fvisibility=hidden) | ||
|
|
||
| # This script file is used to allow exporting pi* symbols only. | ||
| # All other symbols are regarded as local (hidden) | ||
| set(linker_script "${CMAKE_CURRENT_SOURCE_DIR}/../ld-version-script.txt") | ||
|
|
||
| # Filter symbols based on the scope defined in the script file, | ||
| # and export pi* function symbols in the library. | ||
| target_link_libraries( pi_level0 | ||
| target_link_libraries( pi_level_zero | ||
| PRIVATE "-Wl,--version-script=${linker_script}" | ||
| ) | ||
| endif() | ||
|
|
||
| if (TARGET l0-loader) | ||
| add_dependencies(pi_level0 l0-loader) | ||
| add_dependencies(pi_level_zero l0-loader) | ||
| endif() | ||
| add_dependencies(sycl-toolchain pi_level0) | ||
| add_dependencies(sycl-toolchain pi_level_zero) | ||
|
|
||
| target_link_libraries(pi_level0 PRIVATE "${L0_LOADER}") | ||
| target_link_libraries(pi_level_zero PRIVATE "${L0_LOADER}") | ||
|
||
| if (UNIX) | ||
| target_link_libraries(pi_level0 PRIVATE pthread) | ||
| target_link_libraries(pi_level_zero PRIVATE pthread) | ||
| endif() | ||
|
|
||
| add_common_options(pi_level0) | ||
| add_common_options(pi_level_zero) | ||
|
|
||
| install(TARGETS pi_level0 | ||
| LIBRARY DESTINATION "lib" COMPONENT pi_level0 | ||
| RUNTIME DESTINATION "bin" COMPONENT pi_level0) | ||
| install(TARGETS pi_level_zero | ||
| LIBRARY DESTINATION "lib" COMPONENT pi_level_zero | ||
| RUNTIME DESTINATION "bin" COMPONENT pi_level_zero) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"l0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.