[SYCL][CUDA] Event synchronization only done for latest events #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUDA streams operate in-order, so when waiting for a list of events we introduce unnecessary overhead. These changes makes the PI CUDA backend only wait for the latest event for each stream in a given list of events. Signed-off-by: Steffen Larsen <[email protected]>
steffenlarsen
force-pushed
the
steffen/wait-for-latest-event
branch
from
9a41bb7 to
f0f916c
Compare
Signed-off-by: Steffen Larsen <[email protected]>
smaslov-intel
approved these changes
Jun 30, 2020
|
@steffenlarsen, could you take a look at failing test, please? |
I don't think the failure is related to this PR. The changes introduced here are exclusively for PI CUDA, but the failure is using PI OpenCL (on Windows). |
Sorry for the noise, my bad. |
jsji
pushed a commit
that referenced
this pull request
May 15, 2023
This target extension type is created here: https://github.com/intel/vc-intrinsics/blob/master/GenXIntrinsics/lib/GenXIntrinsics/GenXSPIRVWriterAdaptor.cpp#L245 As with other target extension types, reverse translation is not yet supported. Signed-off-by: Sarnie, Nick <[email protected]> Co-authored-by: Victor Mustya <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@60746d5
jsji
pushed a commit
that referenced
this pull request
May 15, 2023
This target extension type is created here: https://github.com/intel/vc-intrinsics/blob/master/GenXIntrinsics/lib/GenXIntrinsics/GenXSPIRVWriterAdaptor.cpp#L245 As with other target extension types, reverse translation is not yet supported. Signed-off-by: Sarnie, Nick <[email protected]> Co-authored-by: Victor Mustya <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@60746d5
jsji
pushed a commit
that referenced
this pull request
May 16, 2023
This target extension type is created here: https://github.com/intel/vc-intrinsics/blob/master/GenXIntrinsics/lib/GenXIntrinsics/GenXSPIRVWriterAdaptor.cpp#L245 As with other target extension types, reverse translation is not yet supported. Signed-off-by: Sarnie, Nick <[email protected]> Co-authored-by: Victor Mustya <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@60746d5
jsji
pushed a commit
that referenced
this pull request
May 16, 2023
This target extension type is created here: https://github.com/intel/vc-intrinsics/blob/master/GenXIntrinsics/lib/GenXIntrinsics/GenXSPIRVWriterAdaptor.cpp#L245 As with other target extension types, reverse translation is not yet supported. Signed-off-by: Sarnie, Nick <[email protected]> Co-authored-by: Victor Mustya <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@60746d5
jsji
pushed a commit
to sys-ce-bb/llvm
that referenced
this pull request
May 16, 2023
This target extension type is created here: https://github.com/intel/vc-intrinsics/blob/master/GenXIntrinsics/lib/GenXIntrinsics/GenXSPIRVWriterAdaptor.cpp#L245 As with other target extension types, reverse translation is not yet supported. Signed-off-by: Sarnie, Nick <[email protected]> Co-authored-by: Victor Mustya <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@60746d5
Closed
jsji
pushed a commit
that referenced
this pull request
May 16, 2023
This target extension type is created here: https://github.com/intel/vc-intrinsics/blob/master/GenXIntrinsics/lib/GenXIntrinsics/GenXSPIRVWriterAdaptor.cpp#L245 As with other target extension types, reverse translation is not yet supported. Signed-off-by: Sarnie, Nick <[email protected]> Co-authored-by: Victor Mustya <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@60746d5
This was referenced May 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA streams operate in-order, so when waiting for a list of events from the same stream we introduce unnecessary overhead. These changes makes the PI CUDA backend only wait for the latest event for each stream in a given list of events.