Skip to content

[SYCL] Deprecate unintentionally public property_list APIs #19789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steffenlarsen merged 3 commits into from
Aug 15, 2025
Merged

[SYCL] Deprecate unintentionally public property_list APIs #19789

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba7d296
[SYCL] Deprecate unintentionally public property_list APIs
steffenlarsen Aug 13, 2025
94c90cc
Refactor approach
steffenlarsen Aug 13, 2025
cc24b0e
Add tests
steffenlarsen Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions sycl/include/sycl/property_list.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ template <typename... PropsT> class accessor_property_list;
} // namespace ext::oneapi
namespace detail {
class PropertyValidator;
class SYCLMemObjT;
} // namespace detail

/// Objects of the property_list class are containers for the SYCL properties
Expand Down Expand Up @@ -58,12 +59,18 @@ class property_list : protected detail::PropertyListBase {
return has_property_helper<PropT>();
}

#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
__SYCL_DEPRECATED("add_or_replace_accessor_properties() is not part of the "
"SYCL API and will be removed in the future.")
void add_or_replace_accessor_properties(const property_list &PropertyList) {
add_or_replace_accessor_properties_helper(PropertyList.MPropsWithData);
}
__SYCL_DEPRECATED("delete_accessor_property() is not part of the SYCL API "
"and will be removed in the future.")
void delete_accessor_property(const sycl::detail::PropWithDataKind &Kind) {
delete_accessor_property_helper(Kind);
}
#endif

template <typename... T> operator ext::oneapi::accessor_property_list<T...>();

Expand All @@ -73,9 +80,19 @@ class property_list : protected detail::PropertyListBase {
std::vector<std::shared_ptr<detail::PropertyWithDataBase>> PropsWithData)
: sycl::detail::PropertyListBase(DataLessProps, PropsWithData) {}

#ifdef __INTEL_PREVIEW_BREAKING_CHANGES
void add_or_replace_accessor_properties(const property_list &PropertyList) {
add_or_replace_accessor_properties_helper(PropertyList.MPropsWithData);
}
void delete_accessor_property(const sycl::detail::PropWithDataKind &Kind) {
delete_accessor_property_helper(Kind);
}
#endif

template <typename... PropsT>
friend class ext::oneapi::accessor_property_list;
friend class detail::PropertyValidator;
friend class detail::SYCLMemObjT;
};

namespace detail {
Expand Down
Loading