Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][CUDA][WIP] PI API Sampler Properties Unit Test #1961

Merged
merged 2 commits into from
Jul 9, 2020
Merged

[SYCL][CUDA][WIP] PI API Sampler Properties Unit Test #1961

merged 2 commits into from
Jul 9, 2020

Conversation

nyalloc
Copy link
Contributor

@nyalloc nyalloc commented Jun 23, 2020 •
edited
Loading

Provides testing for pi_sampler and pi_sampler_properties.

[WIP] Requires #1993 to be merged first.

@nyalloc nyalloc requested a review from a team as a code owner June 23, 2020 19:19
@nyalloc nyalloc requested a review from alexbatashev June 23, 2020 19:19
@bader bader added the cuda CUDA back-end label Jun 24, 2020
@nyalloc nyalloc changed the title [SYCL][CUDA][WIP] Implemented test_sampler_properties.cpp [SYCL][CUDA] Implemented test_sampler_properties.cpp Jun 24, 2020
@nyalloc nyalloc mentioned this pull request Jun 26, 2020
Merged
@nyalloc nyalloc changed the title [SYCL][CUDA] Implemented test_sampler_properties.cpp [SYCL][CUDA] PI API Sampler Properties Unit Test Jun 26, 2020
@bader bader requested a review from alexbatashev June 26, 2020 14:09
@nyalloc nyalloc force-pushed the stuart/SamplerPropertiesTest branch from 394f101 to e32661f Compare June 26, 2020 14:22
@nyalloc nyalloc changed the title [SYCL][CUDA] PI API Sampler Properties Unit Test [SYCL][CUDA][WIP] PI API Sampler Properties Unit Test Jun 26, 2020
alexbatashev
alexbatashev reviewed Jun 26, 2020
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@bader bader requested a review from alexbatashev July 8, 2020 17:18
@bader
Copy link
Contributor

bader commented Jul 8, 2020

Should we remove [WIP] tag from this PR?

@bader bader merged commit 14409c3 into intel:sycl Jul 9, 2020
againull pushed a commit to againull/llvm that referenced this pull request Apr 25, 2023
@vmaksimo @againull
Support translation of DebugFunctionDefinition instruction (intel#1961)
1d69e32 
DebugFunction does not have an Function Id operand in NonSemantic.Shader debug info specification. It's been replaced by the whole new DebugFunctionDefinition instruction to avoid forward references.

This instruction must appear in the entry basic block of an OpFunction.

Specification:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugFunctionDefinition

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@55ce223
againull pushed a commit to againull/llvm that referenced this pull request May 4, 2023
@vmaksimo @againull
Support translation of DebugFunctionDefinition instruction (intel#1961)
093430c 
DebugFunction does not have an Function Id operand in NonSemantic.Shader debug info specification. It's been replaced by the whole new DebugFunctionDefinition instruction to avoid forward references.

This instruction must appear in the entry basic block of an OpFunction.

Specification:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugFunctionDefinition

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@55ce223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev approved these changes

Assignees
No one assigned
Labels
cuda CUDA back-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyalloc @bader @alexbatashev