[CERN] Crash occurs in a IR to SPIRV pass if source file has a custom class with separate constructor declaration and definition. #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksander Fadeev <[email protected]>
fadeeval
changed the title
fadeeval
changed the title
Fznamznon
reviewed
Jun 11, 2020
Comment on lines
+1296
to
+1300
| if (auto Alias = dyn_cast_or_null<llvm::GlobalAlias>(getCalledOperand())) { | ||
| return dyn_cast_or_null<Function>(Alias->getAliasee()); | ||
| } else { | ||
| return dyn_cast_or_null<Function>(getCalledOperand()); | ||
| } |
There was a problem hiding this comment.
Wow, what are you trying to do?
IMO fix should be in the SPIRV translator
fadeeval
deleted the
private/fadeeval/Custom_class_in_SYCL_device_code_crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case separate constructor declaration and definition the IR representation has GlobalAlias objects which didn't process properly in getCalledFunction method of CallInst class.
Signed-off-by: Aleksander Fadeev [email protected]