[SYCL] Use refs to device_impl in ProgramManager #18320
Conversation
Signed-off-by: Sergei Vinogradov <[email protected]>
vinser52
changed the title
| ur::DeviceBinaryType Format = MainImg.getFormat(); | ||
| if (!WorkList.empty() && !checkLinkingSupport(Dev, MainImg)) | ||
| if (!WorkList.empty() && | ||
| !checkLinkingSupport(*getSyclObjImpl(Dev).get(), MainImg)) |
There was a problem hiding this comment.
Why aren't we changing line 691 instead?
There was a problem hiding this comment.
Because I didn't want to refactor the doesDevSupportDeviceRequirements function that internally calls the checkDevSupportDeviceRequirements that uses tempalte <typename Param> device::get_info<Param>
There was a problem hiding this comment.
Ok, I'll look into it separately.
| const bundle_state ImgState = getBinImageState(BinImage); | ||
|
|
||
| assert(compatibleWithDevice(BinImage, Dev)); | ||
| assert(compatibleWithDevice(BinImage, *getSyclObjImpl(Dev).get())); |
There was a problem hiding this comment.
Likewise, line 2554 would be a better change, IMO.
There was a problem hiding this comment.
What about L2567 where we are creating vector of devices? I thoughts it also should be refactored, but in a separate PR?
There was a problem hiding this comment.
What I've been doing during the transition is something like std::vector<device>{createSyclObjFromImpl<device>(Dev.shared_from_this())} but I can follow up on that separately.
2 participants
Refactored the
ProgramManagerto usedevice_impl &instead ofconst device &.See #18270 and #18251 that started the refactoring.