[SYCL][E2E] Use %{run-aux} when removing %t/cache_dir
#18014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logically, it affects subsequent `%{run}` lines so must be done in
run-mode, not in build-mode.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ayylol
approved these changes
Apr 14, 2025
Contributor
ayylol
left a comment
ayylol
left a comment
There was a problem hiding this comment.
LGTM, makes sense since those cache files are produced by the %{run} lines.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
on Arc GPU is unrelated because I haven't touched this test. Search for it hasn't found anything though. |
againull
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logically, it affects subsequent
%{run}lines so must be done in run-mode, not in build-mode.