Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][UR] Unify UR and SYCL benchmarking CI into a single benchmarking CI #17229

Draft
wants to merge 58 commits into
base: sycl
Choose a base branch
from
Draft

[CI][UR] Unify UR and SYCL benchmarking CI into a single benchmarking CI #17229

wants to merge 58 commits into from

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented Feb 27, 2025

No description provided.

pbalcer
pbalcer reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also probably need to modify CODEOWNERS to include the new team, right?

@ianayl
Copy link
Contributor Author

ianayl commented Mar 3, 2025 •
edited
Loading

we also probably need to modify CODEOWNERS to include the new team, right?

Yeah: Although, I'm thinking we do this at the end, when the workflow has taken more shape and we know exactly what locations to add to CODEOWNERS

@ianayl ianayl temporarily deployed to WindowsCILock March 4, 2025 21:21 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 4, 2025 21:36 — with GitHub Actions Inactive
pbalcer and others added 19 commits March 5, 2025 16:32
@pbalcer
[benchmarks] improve HTML and Markdown output
497dcce 
This patch improves numerous aspects on how the benchmarking
results are visualized:
 - rewrites the way HTML charts are generated, using a library (Chart.js)
 that's both easier to use and more visually pleasing.
 The new HTML page also now decouples data from the HTML itself,
 leading to faster load times and the ability to fetch data
 from remote sources.
 - The markdown output now contains a failures section that
 lists all benchmarks that failed for a given run. This will be
 a helpful for developers during PR testing.
 - Benchmarks can now have description that's displayed on the page.
 - And many more minor improvements.
@ianayl
Test UR benchmarking suite
3cbed5e
@ianayl
Merge branch 'unify-benchmark-ci' of https://github.com/intel/llvm in…
1936207 
…to unify-benchmark-ci
@ianayl
Bump tolerance to 7%
f79bbbf
@ianayl
Revert "Bump tolerance to 7%"
ffc8139 
This reverts commit f79bbbf.
@pbalcer
[benchmarks] fix failing benchmarks, improve html output
0a34e0d 
... and add presets to more easily
@pbalcer
[benchmarks] fix python formatting with black
3f42420
@pbalcer
update driver version
1c7b189
@pbalcer
simplify preset implementation and fix normal preset
ad13e93
@ianayl
Add PVC and BMG as runners
68ed0c4
@ianayl
Merge branch 'unify-benchmark-ci' of https://github.com/intel/llvm in…
18fff93 
…to unify-benchmark-ci
@ianayl
Install dependencies before running UR script
3a65b98
@ianayl
Use venv for python packages
220121a
@ianayl
Install venv before using venv
37d361c
@pbalcer
[benchmarks] allow specifying custom results directories
07f1e10
@pbalcer
[benchmarks] sort runs by date for html output
64cf79c
@pbalcer
simplify presets, remove suites if all set
6c28d33
@pbalcer
[benchmarks] use python venv for scripts
e15b94f
@ianayl
Run apt with sudo
78fd037
@ianayl ianayl mentioned this pull request Mar 14, 2025
Closed
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 15:12 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 15:12 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 16:32 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 16:32 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 17:01 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 21:15 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 21:15 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 21:36 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 21:36 — with GitHub Actions Inactive
@ianayl ianayl temporarily deployed to WindowsCILock March 14, 2025 22:02 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ianayl @sarnex @pbalcer @lukaszstolarczuk