[SYCL][DOC] Document -foffload-fp32-prec-div/sqrt options#17033
[SYCL][DOC] Document -foffload-fp32-prec-div/sqrt options#17033aelovikov-intel merged 5 commits intointel:syclfrom
Conversation
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
|
|
||
| ## Other options | ||
|
|
||
| **`-f[no-]offload-fp32-prec-sqrt`** |
There was a problem hiding this comment.
@gmlueck during writing this document I've realized, that there is a similar option already, that works only for CUDA and HIP. I believe, that these options should be merged under sycl-fp32-prec-sqrt name and div option should be renamed to sycl-fp32-prec-div (unless we want to deprecate sycl naming for them, which also might make sense in a certain cases). WDYT?
There was a problem hiding this comment.
I have no strong feelings on which option should remain (offload or sycl), but I do agree that we should merge these.
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
This reverts commit 18c7cc9.
|
@intel/dpcpp-doc-reviewers friendly ping |
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
I would also vote for the discussed merge of existing options, but pure mechanical change LGTM - I don't have objections against documenting the option if we already have it
|
I vote for deprecating |
Supporting doc: #17033 --------- Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
|
Added DEPRECATED note as for other options in the doc, that are being deprecated. Guess no re-review by @AlexeySachkov is required. @intel/llvm-gatekeepers please help with the merge. |
5 participants
No description provided.