[SYCL][E2E] Remove REQUIRES: build-and-run-mode in bindless_images tests
#16789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, some of the tests where I just removed the |
|
@intel/bindless-images-reviewers friendly ping |
przemektmalon
approved these changes
Jan 31, 2025
sycl/test-e2e/bindless_images/vulkan_interop/sampled_images.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/bindless_images/vulkan_interop/sampled_images_USM.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/bindless_images/vulkan_interop/sampled_images_semaphore.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/bindless_images/vulkan_interop/unsampled_images.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/bindless_images/vulkan_interop/unsampled_images_semaphore.cpp
Outdated
Show resolved
Hide resolved
|
Ok, changed the vulkan tests to require |
|
@intel/llvm-gatekeepers this is ready to merge, failure is the same as #16877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #16725 tests can properly react to features that affect compilation on build-only mode (i.e., libraries or OS), additionally we can also mark if a test should only be built for a specific triple using the
target-*features.This pr removes the
REQUIRES: build-and-run-modedirectives from bindless_images tests. These tests will now be marked as unsupported in environments that cannot build the tests due to missing the Vulkan library, or not being on Windows. For two tests removed theREQUIRES: build-and-run-modedirective by changingREQUIRES: cudatoREQUIRES: target-nvidia, this way the tests will only compile for nvidia triple.