Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Add AOT support for device memory sanitizer #16705

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jan 21, 2025

This PR adds AOT device msan library targets for PVC and CPU. These AOT msan libdevice will be linked in AOT compilation.

@jinge90 jinge90 requested review from a team as code owners January 21, 2025 07:14
@jinge90 jinge90 requested a review from uditagarwal97 January 21, 2025 07:14
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in libdevice/cmake/modules/SYCLLibdevice.cmake LGTM.

Signed-off-by: jinge90 <ge.jin@intel.com>
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jinge90 jinge90 requested a review from a team January 28, 2025 09:17
@jinge90
Copy link
Contributor Author

jinge90 commented Jan 28, 2025

Hi, @intel/llvm-gatekeepers
This Pre-ci failure is on AMD platform, this PR doesn't touch AMD, could you take a look and merge this PR?
Thanks very much.

@dm-vodopyanov
Copy link
Contributor

dm-vodopyanov commented Jan 28, 2025

This Pre-ci failure is on AMD platform, this PR doesn't touch AMD

@jinge90, please, check if the same issue has been already submitted to the Issues tab, and if not, create a new one. After that, attach a link to the issue to this PR.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 4, 2025

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@uditagarwal97 uditagarwal97 merged commit 6d883ad into intel:sycl Feb 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants