Skip to content

[SYCL][E2E] Fix unexpectedly passing test on build-only mode #16455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarnex merged 1 commit into from
Dec 23, 2024
Merged

[SYCL][E2E] Fix unexpectedly passing test on build-only mode #16455

sarnex merged 1 commit into from
Dec 23, 2024

Conversation

@ayylol
Copy link
Contributor

@ayylol ayylol commented Dec 23, 2024

This test is able to compile so I am adding XFAIL: run-mode so that it doesn't XPASS on build-only mode. Should fix the pre-commit CI.

@ayylol ayylol requested a review from a team as a code owner December 23, 2024 02:24
@ayylol ayylol mentioned this pull request Dec 23, 2024
Merged
@ayylol
Copy link
Contributor Author

ayylol commented Dec 23, 2024 

UR CUDA ERROR:
	Value:           999
	Name:            CUDA_ERROR_UNKNOWN
	Description:     unknown error
	Function:        operator()
	Source Location: /__w/llvm/llvm/build/_deps/unified-runtime-src/source/adapters/cuda/platform.cpp:80

SYCL Exception encountered: Native API failed. Native API returns: 2147483646 (UR_RESULT_ERROR_UNKNOWN)

Unsure why the CUDA precommit fails here, though it seems unrelated to the changes in this pr.

@sarnex
Copy link
Contributor

sarnex commented Dec 23, 2024

The runner was broken, I restarted it and restarted the job here.

Merging early to fix precommit, please address any feedback from codeowners in follow--up PR

@sarnex sarnex merged commit 1b4e286 into intel:sycl Dec 23, 2024
16 checks passed
YuriPlyakhin
YuriPlyakhin reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@ayylol ayylol deleted the fix-precommit branch December 23, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuriPlyakhin YuriPlyakhin YuriPlyakhin left review comments

@sarnex sarnex sarnex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayylol @sarnex @YuriPlyakhin