[CLC][cmake] Add missing dependency on LIBCLC_LIBRARY_OUTPUT_INTDIR #15366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While processing bc files the OUT_DIR should exist. Sinse we have a separate target for LIBCLC_LIBRARY_OUTPUT_INTDIR, we add a dependency on it instead of forcing directory creation during bc processing.
frasercrmck
approved these changes
Sep 12, 2024
JackAKirk
approved these changes
Sep 12, 2024
Contributor
Author
|
@frasercrmck @JackAKirk could you merge the PR please? The failed |
Contributor
cc @intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While processing bc files, the OUT_DIR should exist. Since we have a separate target for LIBCLC_LIBRARY_OUTPUT_INTDIR, we add a dependency on it instead of forcing directory creation during bc processing.