[NFC] Rename ext_codeplay_enqueue_native_command to ext_oneapi_enqueue_native_command #14854
Conversation
Now that level zero supports this extension, it should be a oneapi ext instead of a codeplay one.
|
Should this bump the UR L0 adapter tag to oneapi-src/unified-runtime#1880 ? |
Yeah spot on actually will do so now |
hdelan
force-pushed
the
codeplay-to-oneapi-ext
branch
from
75edd53 to
169510e
Compare
|
I think we should have the following before we rename:
|
|
The bump for this PR will be included as part of this PR, so we could remove the UR bump here. |
Good shout, when that PR gets merged I'll rebase and get rid of the bump as part of this PR. |
Changes made. Let me know what you think |
|
Please change PR's title to name the extension, instead of just "codeplay extension" that can be misleading. |
hdelan
changed the title
Change made. Thanks |
hdelan
changed the title
sycl/doc/extensions/experimental/sycl_ext_oneapi_enqueue_native_command.asciidoc
Outdated
Show resolved
Hide resolved
| auto DstMem = IH.get_native_mem<backend::ext_oneapi_level_zero>(DstA); | ||
|
|
||
| // If L0 interop becomes a real use case we should make a new UR entry | ||
| // point to propagate events into and out of the the interop func. |
There was a problem hiding this comment.
What does this comment mean?
There was a problem hiding this comment.
In order to make this entry point more performant on L0 we would need something like the previous host task extensions so we can pass in and out events to the ze call.
As it stands there is no point making this more performant for L0 since no one that we are aware of are using L0 interop in SYCL.
There was a problem hiding this comment.
????
We have had a SYCL Level Zero interop specification for a long time and many people are using it.
sycl/test-e2e/EnqueueNativeCommand/custom-command-level-zero.cpp
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_enqueue_native_command.asciidoc
Outdated
Show resolved
Hide resolved
Use accessor::size instead of get_count.
Use accessors to show where src and dst come from and use accessor::size instead of accessor::get_count. Also update comment to say command list instead of stream.
|
Closing as no longer required |
5 participants
Now that level zero supports this extension as of
oneapi-src/unified-runtime#1880, this extension should be a oneapi
ext instead of a codeplay one.