[SYCL] Replace __spirv_SubgroupShuffle{...}INTEL with __spirv_GroupNonUniformShuffle{...} generic versions. #14748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L, __spirv_SubgroupShuffleDownINTEL and __spirv_SubgroupShuffleUpINT with __spirv_GroupNonUniformShuffle... generic versions.
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hi @al3x-jp! I took the liberty of rebasing this patch, applying clang-format, and fixing the test issues. Hope is that the CI should be green shortly. |
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Seems to be some unexpected failures on Gen12. I will look into this ASAP. |
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
changed the title
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Seems that OpenCL doesn't allow vectors in SPIR-V shuffle operations. By scalarizing the vectors we can work around this, expecting the device-compiler to vectorize the operation if it sees fit. The remaining failure in syclcompat om CPU seems like a bug in the CPU device compiler which shuffles in the wrong direction under certain circumstances. It has been reported to the CPU device-compiler team. |
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced __spirv_SubgroupShuffleINTEL, __spirv_SubgroupShuffleXorINTEL, __spirv_SubgroupShuffleDownINTEL and __spirv_SubgroupShuffleUpINT with __spirv_GroupNonUniformShuffle... generic versions.
According to the OpenCL Specification, these operations only accept scalars, so we force vectorization of vectors.