[SYCL][PI] Add some fixes relevant to adapters second bump PR #11771

omarahmed1111 · 2023-11-03T11:02:40Z

This PR add some fixes that is needed after adapters branch second bump PR, it needs only to me merged after the second bump PR for adapters branch is merged.

Depends on this PR

jandres742 · 2023-11-14T01:57:47Z

sycl/plugins/unified_runtime/pi2ur.hpp

@@ -2336,8 +2331,18 @@ inline pi_result piKernelGetInfo(pi_kernel Kernel, pi_kernel_info ParamName,
    break;
  }
  case PI_KERNEL_INFO_NUM_ARGS: {
-    UrParamName = UR_KERNEL_INFO_NUM_ARGS;
-    break;
+    size_t NumArgs = 0;


why do we need this change? this seems like something it should go in a completely separate patch so in case there are regressions it is easy to identify.

without this one of the fixes we're pulling in causes a regression

This changes was temporarily until this PR is merged. This changes have been reverted and the PR was rebased on recent SYCL branch.

omarahmed1111 · 2023-11-16T15:52:18Z

Due to a windows failure that will be fixed here and to make it easier, we will combine the second and third bump into one here. So closing this for now.

omarahmed1111 had a problem deploying to WindowsCILock November 3, 2023 11:19 — with GitHub Actions Failure

omarahmed1111 mentioned this pull request Nov 3, 2023

Second patch of bumping adapters branch oneapi-src/unified-runtime#1014

Closed

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch 3 times, most recently from 70b08ff to 50bce15 Compare November 3, 2023 14:49

omarahmed1111 had a problem deploying to WindowsCILock November 3, 2023 15:10 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 50bce15 to dd2a3f4 Compare November 3, 2023 16:05

omarahmed1111 had a problem deploying to WindowsCILock November 3, 2023 16:45 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from dd2a3f4 to 3e54d64 Compare November 6, 2023 12:27

omarahmed1111 had a problem deploying to WindowsCILock November 6, 2023 12:29 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 3e54d64 to 3d3b395 Compare November 6, 2023 12:32

omarahmed1111 temporarily deployed to WindowsCILock November 6, 2023 12:33 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 6, 2023 12:53 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 3d3b395 to 3e047c6 Compare November 7, 2023 10:34

omarahmed1111 temporarily deployed to WindowsCILock November 7, 2023 10:35 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 7, 2023 10:57 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 3e047c6 to 875c73b Compare November 7, 2023 14:12

omarahmed1111 temporarily deployed to WindowsCILock November 7, 2023 14:13 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 7, 2023 14:35 — with GitHub Actions Failure

omarahmed1111 temporarily deployed to WindowsCILock November 7, 2023 15:45 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 7, 2023 15:46 — with GitHub Actions Error

omarahmed1111 temporarily deployed to WindowsCILock November 7, 2023 17:18 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 7, 2023 17:18 — with GitHub Actions Failure

omarahmed1111 changed the title ~~Testing for UR adapter branch bump second patch~~ [SYCL][PI] Add some fixes relevant to adapters second bump PR Nov 8, 2023

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch 3 times, most recently from a8aecba to c45bdbf Compare November 8, 2023 10:56

omarahmed1111 marked this pull request as ready for review November 8, 2023 10:59

omarahmed1111 requested review from a team as code owners November 8, 2023 10:59

omarahmed1111 had a problem deploying to WindowsCILock November 10, 2023 01:39 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 081b046 to 61fdf1f Compare November 10, 2023 12:08

omarahmed1111 temporarily deployed to WindowsCILock November 10, 2023 12:09 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 10, 2023 12:29 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 61fdf1f to 3941a2d Compare November 10, 2023 15:30

omarahmed1111 had a problem deploying to WindowsCILock November 10, 2023 15:31 — with GitHub Actions Failure

omarahmed1111 had a problem deploying to WindowsCILock November 10, 2023 15:50 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 3941a2d to 351b253 Compare November 10, 2023 19:44

omarahmed1111 had a problem deploying to WindowsCILock November 10, 2023 19:47 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 351b253 to acc1453 Compare November 10, 2023 21:13

omarahmed1111 had a problem deploying to WindowsCILock November 10, 2023 21:14 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from acc1453 to a37ad30 Compare November 10, 2023 22:24

omarahmed1111 had a problem deploying to WindowsCILock November 10, 2023 22:26 — with GitHub Actions Failure

omarahmed1111 had a problem deploying to WindowsCILock November 10, 2023 22:52 — with GitHub Actions Failure

omarahmed1111 temporarily deployed to WindowsCILock November 11, 2023 00:09 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 11, 2023 00:36 — with GitHub Actions Failure

jandres742 reviewed Nov 14, 2023

View reviewed changes

kbenzie mentioned this pull request Nov 14, 2023

[UR][L0] Add support for passing device list to urProgramBuild/Link/Compile oneapi-src/unified-runtime#934

Merged

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch 2 times, most recently from 42d8941 to 9254758 Compare November 14, 2023 21:20

omarahmed1111 temporarily deployed to WindowsCILock November 14, 2023 21:21 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 14, 2023 21:43 — with GitHub Actions Failure

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from 9254758 to c760d41 Compare November 14, 2023 22:08

omarahmed1111 had a problem deploying to WindowsCILock November 14, 2023 22:12 — with GitHub Actions Failure

Add some fixes relevant to adapters second bump

28b2b5b

omarahmed1111 force-pushed the testing-pr-for-adapter-bump-second-patch branch from c760d41 to 28b2b5b Compare November 15, 2023 09:28

omarahmed1111 temporarily deployed to WindowsCILock November 15, 2023 09:30 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock November 15, 2023 09:50 — with GitHub Actions Failure

omarahmed1111 closed this Nov 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL][PI] Add some fixes relevant to adapters second bump PR #11771

[SYCL][PI] Add some fixes relevant to adapters second bump PR #11771

omarahmed1111 commented Nov 3, 2023 •

edited

Loading

jandres742 Nov 14, 2023

aarongreig Nov 14, 2023

omarahmed1111 Nov 15, 2023

omarahmed1111 commented Nov 16, 2023

[SYCL][PI] Add some fixes relevant to adapters second bump PR #11771

[SYCL][PI] Add some fixes relevant to adapters second bump PR #11771

Conversation

omarahmed1111 commented Nov 3, 2023 • edited Loading

jandres742 Nov 14, 2023

Choose a reason for hiding this comment

aarongreig Nov 14, 2023

Choose a reason for hiding this comment

omarahmed1111 Nov 15, 2023

Choose a reason for hiding this comment

omarahmed1111 commented Nov 16, 2023

omarahmed1111 commented Nov 3, 2023 •

edited

Loading