Skip to content

[SYCL] Reject zero length arrays #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 19 commits into from
Mar 3, 2020
Merged

[SYCL] Reject zero length arrays #1153

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
eaa10ea
disallow zero length arrays in SYCL kernels
cperkinsintel Feb 15, 2020
e9dd04a
changing diagnostic code per feedback
cperkinsintel Feb 20, 2020
765d43b
remove braces, per PR request
cperkinsintel Feb 20, 2020
fb3d2ac
adding test of deferred diagnostics, per PR request
cperkinsintel Feb 20, 2020
9618333
improved deferred diagnostic testing
cperkinsintel Feb 20, 2020
cc9aa9f
Update clang/test/SemaSYCL/deferred-diagnostics-emit.cpp
cperkinsintel Feb 21, 2020
8d92c4d
switched to common fake SYCL scaffolding
cperkinsintel Feb 21, 2020
17a2f44
Update clang/lib/Sema/SemaType.cpp
cperkinsintel Feb 21, 2020
b8a67d3
changing comment formatting per PR feedback
cperkinsintel Feb 21, 2020
e28c09e
Update clang/test/SemaSYCL/deferred-diagnostics-emit.cpp
cperkinsintel Feb 21, 2020
8634c6e
Update clang/test/SemaSYCL/deferred-diagnostics-emit.cpp
cperkinsintel Feb 25, 2020
0a208a1
updating test. Having problem with 'note' expectation.
cperkinsintel Feb 25, 2020
b515e70
Merge branch 'cperkins-sycl-reject-zero-length-arrays' of https://git…
cperkinsintel Feb 25, 2020
a1c2eb3
llvm-lit test passing
cperkinsintel Feb 26, 2020
11b2e94
clang-format
cperkinsintel Feb 26, 2020
7d7a2ec
quick comm
cperkinsintel Feb 26, 2020
77a5c88
cf trouble
cperkinsintel Feb 27, 2020
f63f410
comment
cperkinsintel Feb 27, 2020
dd87de2
lightening test
cperkinsintel Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions clang/lib/Sema/SemaType.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2340,6 +2340,13 @@ QualType Sema::BuildArrayType(QualType T, ArrayType::ArraySizeModifier ASM,
<< ArraySize->getSourceRange();
ASM = ArrayType::Normal;
}

// SYCL kernels reject zero length arrays
if (getLangOpts().SYCLIsDevice) {
SYCLDiagIfDeviceCode(ArraySize->getBeginLoc(),
diag::err_typecheck_zero_array_size)
<< ArraySize->getSourceRange();
}
} else if (!T->isDependentType() && !T->isVariablyModifiedType() &&
!T->isIncompleteType() && !T->isUndeducedType()) {
// Is the array too large?
Expand Down
3 changes: 3 additions & 0 deletions clang/test/SemaSYCL/sycl-restrict.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ void usage(myFuncDef functionPtr) {

// expected-error@+1 {{__float128 is not supported on this target}}
__float128 A;

// expected-error@+1 {{zero-length arrays are not permitted in C++}}
int BadArray[0];
}

namespace ns {
Expand Down