Skip to content

[NFC][Opaque Pointer][clang] Remove code within ifndef INTEL_SYCL_OPAQUEPOINTER_READY #11059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aelovikov-intel merged 2 commits into from
Sep 6, 2023
Merged

[NFC][Opaque Pointer][clang] Remove code within ifndef INTEL_SYCL_OPAQUEPOINTER_READY #11059

aelovikov-intel merged 2 commits into from
Sep 6, 2023

Conversation

@jsji
Copy link
Contributor

@jsji jsji commented Sep 5, 2023 •
edited
Loading

  • Remove code in INTEL_SYCL_OPAQUEPOINTER_READY==0
  • clang-format

This should be NFC, as INTEL_SYCL_OPAQUEPOINTER_READY is always 1 since #10888 .

@jsji jsji marked this pull request as ready for review September 5, 2023 20:21
@jsji jsji requested review from a team as code owners September 5, 2023 20:21
@jsji jsji self-assigned this Sep 5, 2023
@jsji jsji mentioned this pull request Sep 6, 2023
Merged
@jsji jsji changed the title [Opaque Pointer][clang] Remove code within ifndef INTEL_SYCL_OPAQUEPOINTER_READY [NFC][Opaque Pointer][clang] Remove code within ifndef INTEL_SYCL_OPAQUEPOINTER_READY Sep 6, 2023
@jsji
Copy link
Contributor Author

jsji commented Sep 6, 2023

Ping @intel/dpcpp-clang-driver-reviewers @intel/dpcpp-cfe-reviewers . Thanks.

@jsji jsji requested a review from bader September 6, 2023 18:55
mdtoguchi
mdtoguchi approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for driver

smanna12
smanna12 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes LGTM

@jsji
Copy link
Contributor Author

jsji commented Sep 6, 2023

@intel/llvm-gatekeepers Can we get this merged? Thanks!

@aelovikov-intel aelovikov-intel merged commit cb34ea9 into intel:sycl Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@bader bader Awaiting requested review from bader

+1 more reviewer

@smanna12 smanna12 smanna12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jsji jsji

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsji @mdtoguchi @elizabethandrews @smanna12 @aelovikov-intel