-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][CUDA][HIP] Deprecate context interop for CUDA and HIP #10975
[SYCL][CUDA][HIP] Deprecate context interop for CUDA and HIP #10975
Conversation
2dde128
to
36fbb6e
Compare
Some further description: The This dual impl has been harmless up until now since the context has been constrained to a single device. However #10737 introduces behaviour that if we have two devices in a single platform (ie two CUDA devices) then the default context will contain them both. Therefore if users are using the experimental interface for For this reason I think it is better to deprecate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ping @intel/llvm-gatekeepers can we merge this please? |
|
It seems that |
@aelovikov-intel test should be fixed now, but still surprising that this is running for the AMD triple |
I think the semantics of LIT features might be different between I'm not driver expert, but might it be that we specify some options to be used when targeting AMD, but then don't actually target it? IMO, that would be consistent with the "argument unused during compilation" warning we saw in that test run. |
The
sycl::context
does not map clearly to a native context for CUDA and HIP backends. This is especially true now that we are adding support for multi device context #10737 . It would be good to start this deprecation process. PRs to oneMKL and oneDNN to follow