[SYCL][Graph] Correct assert usage #10969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix [macOS CI fail in post-commit CI] (https://github.com/intel/llvm/actions/runs/5975037762/job/16210261083) by asserting on `false`, then providing the error string. ``` /Users/runner/work/llvm/llvm/src/sycl/source/detail/graph_impl.cpp:140:16: error: implicit conversion turns string literal into bool: 'const char[55]' to 'bool' [-Werror,-Wstring-conversion] assert("Node duplication failed. A duplicated node is missing."); ~~~~~~~^~~~~~~~~~~~~~~~~~~ ```
mfrancepillois
approved these changes
Aug 25, 2023
reble
changed the title
bader
reviewed
Aug 25, 2023
sycl/source/detail/graph_impl.cpp
Outdated
| assert("Node duplication failed. A duplicated node is missing."); | ||
| assert(false && | ||
| "Node duplication failed. A duplicated node is missing."); | ||
| } |
Contributor
There was a problem hiding this comment.
You don't need to if statement in this case. Just move the condition to assert.
assert(NodesMap.find(NextNode) != NodesMap.end() && "Node duplication failed. A duplicated node is missing.");
auto Successor = NodesMap[NextNode];
NodeCopy->registerSuccessor(Successor, NodeCopy);
Contributor
Contributor
There was a problem hiding this comment.
Maybe we can use at instead of operator [] to make out-of-bounds check by std::map and remove assert from the code? NOTE: this will enable the check in Release mode too, which might be not intended.
Contributor
Author
There was a problem hiding this comment.
@reble has pushed an update so that this PR uses at
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix macOS CI fail in post-commit CI by asserting on
false, then providing the error string.Error