[Opaque Pointer] Fix bad code within INTEL_SYCL_OPAQUEPOINTER_READY #10870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa84874 Added the cast , we should keep it in opaque pointer path.
Contributor
Author
Contributor
Author
MrSidims
approved these changes
Aug 21, 2023
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
not sure, why tools team is summoned as code owners here, files are quite out of scope of our expertise
yet the changes look legit
Contributor
Author
|
Thanks @MrSidims !
We have intel/dpcpp-tools-reviewers as code owner of ALL llvm changes. Is this intended? If not, we probably should update it. |
Fznamznon
reviewed
Aug 21, 2023
Co-authored-by: Mariya Podchishchaeva <[email protected]>
jsji
commented
Aug 21, 2023
| VFunc = CGF.EmitVTableTypeCheckedLoad( | ||
| #ifdef INTEL_SYCL_OPAQUEPOINTER_READY | ||
| MethodDecl->getParent(), VTable, PtrTy, | ||
| #else |
Contributor
Author
There was a problem hiding this comment.
Looks like to me that we can avoid this #ifdef if we do the rename of TyPtr to PtrTy.
Other than this, we have to keep all the other #ifdef anyway, due to call to ->getPoitnerTo() , BitCast etc.
Fznamznon
approved these changes
Aug 22, 2023
Contributor
Author
|
@intel/llvm-gatekeepers Can we get this merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for setting -DINTEL_SYCL_OPAQUEPOINTER_READY=1