[HIP][UR] Use primary context in HIP adapter #10514
Conversation
| @@ -1287,6 +1287,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMPrefetch( | |||
| ur_queue_handle_t hQueue, const void *pMem, size_t size, | |||
| ur_usm_migration_flags_t flags, uint32_t numEventsInWaitList, | |||
| const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) { | |||
| #if HIP_VERSION_MAJOR >= 5 | |||
There was a problem hiding this comment.
Also adding this check since hipPointerGetAttribute is not supported in HIP versions < 5
|
The |
|
Thanks @jandres742 . I feel like @intel/llvm-reviewers-cuda are probably the most relevant for reviewing HIP adapter stuff |
|
@intel/llvm-gatekeepers this can be merged |
|
Also would it be worth changing @intel/llvm-reviewers-cuda to intel/llvm-reviewers-cuda-hip ? |
|
Technically @intel/dpcpp-l0-pi-reviewers approval is required, but it seems like this has already been considered and that we might want to fix the ownership here. Merging without. |
|
#10580 should change ownership of the plugin. Whether or not the group should be renamed is something we can discuss further. |
|
Nice thanks @steffenlarsen ! |
The primary context has been default for a while in CUDA PI/Adapter. See intel#8197. This PR brings the HIP adapter up to speed. It also changes the scoped context to only take a `ur_device_handle_t` since this is coupled with a native primary context in HIP
The primary context has been default for a while in CUDA PI/Adapter. See intel#8197. This PR brings the HIP adapter up to speed. It also changes the scoped context to only take a `ur_device_handle_t` since this is coupled with a native primary context in HIP
A typo in #10514 got rid of the extended deleter callbacks. This reinstates them. --------- Co-authored-by: aelovikov-intel <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
The primary context has been default for a while in CUDA PI/Adapter. See #8197.
This PR brings the HIP adapter up to speed.
It also changes the scoped context to only take a
ur_device_handle_tsince this is coupled with a native primary context in HIP