Skip to content

Commit

Permalink
[SYCL] Remove unecessary cc change
Browse files Browse the repository at this point in the history
  • Loading branch information
jsji committed Jan 30, 2025
1 parent 16914cb commit 594e3ce
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 11 deletions.
1 change: 0 additions & 1 deletion llvm/lib/SYCLLowerIR/SYCLCreateNVVMAnnotations.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ static void addNVVMMetadata(Function &F, StringRef Name, int Operand) {
ConstantAsMetadata::get(
ConstantInt::get(Type::getInt32Ty(Ctx), Operand))};
// Append metadata to nvvm.annotations
F.setCallingConv(CallingConv::PTX_Kernel);
MD->addOperand(MDNode::get(Ctx, MDVals));
}

Expand Down
20 changes: 10 additions & 10 deletions llvm/test/SYCLLowerIR/nvvm-annotations.ll
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals all --version 5
; RUN: opt -passes=sycl-create-nvvm-annotations -S < %s | FileCheck %s

define void @foo_reqd0() !reqd_work_group_size !6 {
define ptx_kernel void @foo_reqd0() !reqd_work_group_size !6 {
; CHECK-LABEL: define ptx_kernel void @foo_reqd0(
; CHECK-SAME: ) !reqd_work_group_size [[META18:![0-9]+]] {
; CHECK-NEXT: ret void
;
ret void
}

define void @foo_reqd1() !work_group_num_dim !1 !reqd_work_group_size !4 {
define ptx_kernel void @foo_reqd1() !work_group_num_dim !1 !reqd_work_group_size !4 {
; CHECK-LABEL: define ptx_kernel void @foo_reqd1(
; CHECK-SAME: ) !reqd_work_group_size [[META19:![0-9]+]] !work_group_num_dim [[META20:![0-9]+]] {
; CHECK-NEXT: ret void
;
ret void
}

define void @foo_reqd2() !work_group_num_dim !2 !reqd_work_group_size !5 {
define ptx_kernel void @foo_reqd2() !work_group_num_dim !2 !reqd_work_group_size !5 {
; CHECK-LABEL: define ptx_kernel void @foo_reqd2(
; CHECK-SAME: ) !reqd_work_group_size [[META21:![0-9]+]] !work_group_num_dim [[META22:![0-9]+]] {
; CHECK-NEXT: ret void
;
ret void
}

define void @foo_reqd3() !work_group_num_dim !3 !reqd_work_group_size !6 {
define ptx_kernel void @foo_reqd3() !work_group_num_dim !3 !reqd_work_group_size !6 {
; CHECK-LABEL: define ptx_kernel void @foo_reqd3(
; CHECK-SAME: ) !reqd_work_group_size [[META18]] !work_group_num_dim [[META23:![0-9]+]] {
; CHECK-NEXT: ret void
Expand All @@ -35,47 +35,47 @@ define void @foo_reqd3() !work_group_num_dim !3 !reqd_work_group_size !6 {

; Check that padding is ignored: we should only read the first dimension of the
; 3D metadata
define void @foo_reqd4() !work_group_num_dim !1 !reqd_work_group_size !6 {
define ptx_kernel void @foo_reqd4() !work_group_num_dim !1 !reqd_work_group_size !6 {
; CHECK-LABEL: define ptx_kernel void @foo_reqd4(
; CHECK-SAME: ) !reqd_work_group_size [[META18]] !work_group_num_dim [[META20]] {
; CHECK-NEXT: ret void
;
ret void
}

define void @foo_max0() !work_group_num_dim !1 !max_work_group_size !6 {
define ptx_kernel void @foo_max0() !work_group_num_dim !1 !max_work_group_size !6 {
; CHECK-LABEL: define ptx_kernel void @foo_max0(
; CHECK-SAME: ) !work_group_num_dim [[META20]] !max_work_group_size [[META18]] {
; CHECK-NEXT: ret void
;
ret void
}

define void @foo_max1() !work_group_num_dim !2 !max_work_group_size !6 {
define ptx_kernel void @foo_max1() !work_group_num_dim !2 !max_work_group_size !6 {
; CHECK-LABEL: define ptx_kernel void @foo_max1(
; CHECK-SAME: ) !work_group_num_dim [[META22]] !max_work_group_size [[META18]] {
; CHECK-NEXT: ret void
;
ret void
}

define void @foo_max2() !work_group_num_dim !3 !max_work_group_size !6 {
define ptx_kernel void @foo_max2() !work_group_num_dim !3 !max_work_group_size !6 {
; CHECK-LABEL: define ptx_kernel void @foo_max2(
; CHECK-SAME: ) !work_group_num_dim [[META23]] !max_work_group_size [[META18]] {
; CHECK-NEXT: ret void
;
ret void
}

define void @foo_minwgpercu0() !min_work_groups_per_cu !2 {
define ptx_kernel void @foo_minwgpercu0() !min_work_groups_per_cu !2 {
; CHECK-LABEL: define ptx_kernel void @foo_minwgpercu0(
; CHECK-SAME: ) !min_work_groups_per_cu [[META22]] {
; CHECK-NEXT: ret void
;
ret void
}

define void @foo_maxwgpermp() !max_work_groups_per_mp !3 {
define ptx_kernel void @foo_maxwgpermp() !max_work_groups_per_mp !3 {
; CHECK-LABEL: define ptx_kernel void @foo_maxwgpermp(
; CHECK-SAME: ) !max_work_groups_per_mp [[META23]] {
; CHECK-NEXT: ret void
Expand Down

0 comments on commit 594e3ce

Please sign in to comment.