This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Release specialization constant buffer#643
Merged
vladimirlaz merged 14 commits intointel:intelfrom Dec 27, 2021
Merged
Conversation
HabKaffee
requested review from
bader,
kbobrovs and
romanovvlad
as code owners
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
Some minor comments, but generally it looks good.
|
@kbobrovs, ping. |
Author
|
Nothing new was added by last commit. |
Author
|
|
bader
pushed a commit
to intel/llvm
that referenced
this pull request
Dec 23, 2021
This patch releases spec const buffer implementation. Tests is placed to llvm-test-suite - intel/llvm-test-suite#643
HabKaffee
changed the title
vladimirlaz
approved these changes
Dec 27, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes tests for implemented spec const buffer.
Implementation in intel/llvm.
link to PR with implementation: intel/llvm#5167