This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] removal of sycl-ls-unified-runtime test#1491
Closed
cperkinsintel wants to merge 1 commit intointel:intelfrom
Closed
[SYCL] removal of sycl-ls-unified-runtime test#1491cperkinsintel wants to merge 1 commit intointel:intelfrom
cperkinsintel wants to merge 1 commit intointel:intelfrom
Conversation
…n't do. Platforms without devices are not listed nor reported to the user. I'm not sure of an alternate way of detecting the presence of the UR. Perhaps one of its functions could output when SYCL_PI_TRACE=2 ?
|
@cperkinsintel : could we keep the test disabled? I expect soon devices will be reported by UR and then it can be re-enabled |
Author
|
@smaslov-intel - yes, I can do that. I'll just close this PR and open a different one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test depends upon SYCL gathering up empty platforms, which we don't do. Platforms without devices are not listed nor reported to the user. I'm not sure of an alternate way of detecting the presence of the UR. Perhaps one of its functions could output when SYCL_PI_TRACE=2 ?
See also intel/llvm#7923