This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] updating device selectors#1160
Merged
againull merged 15 commits intointel:intelfrom Oct 3, 2022
Merged
Conversation
…SYCL 2020 ones Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Author
|
/verify with intel/llvm#6599 |
AlexeySachkov
previously approved these changes
Aug 18, 2022
v-klochkov
reviewed
Aug 18, 2022
v-klochkov
left a comment
v-klochkov
left a comment
There was a problem hiding this comment.
Looks good in general, but there is 1 or 2 test fails caused by this PR.
In particular program_link.cpp fail (syntax error) is definitely caused by this change.
Author
|
will have a failure in |
v-klochkov
previously approved these changes
Aug 19, 2022
AlexeySachkov
previously approved these changes
Sep 6, 2022
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
v-klochkov
previously approved these changes
Sep 8, 2022
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
v-klochkov
approved these changes
Sep 10, 2022
Author
|
ping to reviewers. I had to set this aside to work on something else, but now it has been deconflicted again and is passing all tests. Would love to get this in and merged. This PR mostly just replaces instances of |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
The SYCL 1.2.1 style device_selector subclasses are now deprecated. In this PR we are updating the tests to use the newer SYCL 2020 ones. This avoids encountering all the "deprecation" warnings when running verbose tests.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
The SYCL 1.2.1 style device_selector subclasses are now deprecated. In this PR we are updating the tests to use the newer SYCL 2020 ones. This avoids encountering all the "deprecation" warnings when running verbose tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SYCL 1.2.1 style device_selector subclasses are now deprecated. In this PR we are updating the tests to use the newer SYCL 2020 ones. This avoids encountering all the "deprecation" warnings when running verbose tests.
The deprecation warnings are being added in intel/llvm#6599 .
Signed-off-by: Chris Perkins chris.perkins@intel.com