This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][CUDA] Revert experimental/builtins.hpp includes #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
|
/verify with intel/llvm#6400 |
bader
approved these changes
Jul 5, 2022
v-klochkov
approved these changes
Jul 5, 2022
bader
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 11, 2022
Reverts #6386 so that experimental/builtins.hpp is included in sycl.hpp. This avoids users being required to include this header when using printf or experimental math functions. Corresponding update here: intel/llvm-test-suite#1076.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Reverts experimental/builtins.hpp includes added in intel#1072 and intel#1075. Requires: intel/llvm#6400
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…st-suite#1076) Reverts experimental/builtins.hpp includes added in intel/llvm-test-suite#1072 and intel/llvm-test-suite#1075. Requires: intel#6400
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts experimental/builtins.hpp includes added in #1072 and #1075.
Requires: intel/llvm#6400