-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: add wrapper code for ITT-NERSC implementation to ensure compatibility #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy51
reviewed
Jul 23, 2024
abrown
reviewed
Jul 24, 2024
… itt_NERSC in NERSC_collection_control_sample.py
…ction of ittapi module
Andy51
reviewed
Jul 30, 2024
Andy51
approved these changes
Jul 31, 2024
eparshut
reviewed
Aug 2, 2024
eparshut
reviewed
Aug 2, 2024
eparshut
reviewed
Aug 2, 2024
eparshut
reviewed
Aug 2, 2024
eparshut
reviewed
Aug 2, 2024
eparshut
reviewed
Aug 5, 2024
eparshut
reviewed
Aug 5, 2024
eparshut
changed the title
added the wrapper code for ITT-NERSC implementation
python: add wrapper code for ITT-NERSC implementation to ensure compatibility
Aug 6, 2024
eparshut
approved these changes
Aug 6, 2024
I left some suggested edits, mostly nits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the NERSC implementation of ITT API(Link), there are 9 functions.
Each of the function is listed below with the description about the changes done to support them.
resume
implementation inittapi
.pause
implementation inittapi
.detach
implementation inittapi
.domain
implementation inittapi
and renamed it asdomain_create
.task_begin
implementation inittapi
, so have used that API function directly with only change that inittapi
, intask_begin
is expected to have task name inStringHandle
format. So, this change is done and existing API is used afterward.task_end
implementation inittapi
, so have used that API function directly.pt_region
is one of things that's not thereittapi
implementation. So, to support this, a new structure to handlept_region
is created along with utility functions to handle them in [pt_region.hpp, pt_region.cpp]. As a new structure is created so listed that at [ittapi.cpp]pt_region_begin
which in turn is implemented in [pt_region.cpp].pt_region_end
which in turn is implemented in [pt_region.cpp].A separate module
ittapi.compat
for NERSC implementation is created, thus the folderittapi/compat/
andittapi/compat/__init__.py
listing all the supported functions by the module.To include and build the newly created cpp file
pt_region.cpp
,setup.py
is changed.Rest of the changes are to add the unit test cases for the module
ittapi.compat
added.