-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python support to ITT API #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eparshut asked me to take a look at this so here are some thoughts:
- First, I think this is great! Having control over collection in more languages is extremely helpful; I wasn't even aware this existed until I saw it upstreamed here.
- A naming nit: I would probably go with
python
as the top-level directory for this code to match therust
directory. And I would have expected the PyPI package to be namedittapi
, but it's probably too late to change that. - I noticed different coding styles throughout; maybe we should add a formatter pass in CI
- Which brings me to CI: this addition would really benefit from building itself in a GitHub workflow, running the tests, running lints, etc.
Let me ditto @abrown here:
|
The usage of Intel email address is not align with Own-Time Open Source Project Approval that pyitt has. Therefore, please use original email address or just remove it at all from pyproject.toml. |
Add Python binding to ITT API.
Many kudos to @esuldin for the work done and his contribution.