Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed nmake to build against MSVCRT (/MD, /MDd) #157

Closed
wants to merge 1 commit into from

Conversation

gh-andre
Copy link

@gh-andre gh-andre commented Feb 2, 2025

  • When the runtime type option is omitted, VC++ builds object files with a LIBCMT directive, which is a thread-safe CRT statically linked runtime library.
  • This change adds explicit release and debug dynamic CRT options into build configurations.

* When the runtime type option is omitted, VC++ builds object
  files with a `LIBCMT` directive, which is a thread-safe CRT
  statically linked runtime library.
* This change adds explicit release and debug dynamic CRT
  options into build configurations.
@pablodelara
Copy link
Contributor

Thanks for this PR, @gh-andre. Could you sign off the commit as per the contributing guidelines? Thanks!

@gh-andre
Copy link
Author

gh-andre commented Feb 6, 2025

I don't have GPG setup to sign commits and these 2 lines are not worth the trouble. Just apply the patch from the issue, if you want to fix Windows builds.

@gh-andre gh-andre closed this Feb 6, 2025
@pablodelara
Copy link
Contributor

Hi @gh-andre. Actually, it doesn't involve any GPG. All you would need to do is use "git commit -s" to add the "Signed-off-by" line, with your name and email. Agree that I can just take the code and apply it, but I want you to get the credit. Thanks for your work.

@gh-andre
Copy link
Author

gh-andre commented Feb 7, 2025

Thanks for your kind words. I'm pretty sure it requires some setup for this command to work, but I will give it a try this weekend and will let you know.

@gh-andre
Copy link
Author

gh-andre commented Feb 9, 2025

@pablodelara I clearly misunderstood the --signoff option in that it only made sense in my mind if this sign-off was cryptographically signed. My bad.

I added the sign-off trailer in a new pull request. Have a look, and if I messed up anything else, please feel free to reject the pull request and just grab the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants