-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Galaxy Book4 Pro compatibility #230
Conversation
I'm also doing similar changes, but I didn't know that there are also hardware configurations like "ov02c10 + discrete power control" without IVSC. This version looks good, but let me verify if it works on my side. By the way, how do you think use dev_dbg instead of dev_info in commit "print module name"? dev_info maybe too noisy. |
Sure thing :)
Yup, that makes sense. I've updated the PR. |
Thanks @arter97 , I merged my changes to your patches and pushed here and a simple test on my side is good. Could you help review that and test if it works for you? Currently ov02c10 has been used in many devices with IPU6 in different hardware configurations. I think we'd better review and test more before we merge this PR. |
Yup, it works correctly on my end too. I noticed that this part is missing though:
I'm assuming you'd know better but just wanted to point that out if deleting that was a mistake. Regardless, it's all working fine on my end :) Let me know if you want me to update this PR to your latest tree directly. |
Thanks,
This part is moved to ov02c10_power_on() so we can replace this by ov02c10_power_on().
I need to do more test on my side, maybe my branch still need some changes. Will let you know if everything works well. |
Signed-off-by: Juhyung Park <[email protected]> Signed-off-by: Hao Yao <[email protected]>
The KBFC645 module used in Galaxy Book4 Pro also needs 180 rotation. Signed-off-by: Juhyung Park <[email protected]> Signed-off-by: Hao Yao <[email protected]>
This should come in handy when debugging module-specific issues. Signed-off-by: Juhyung Park <[email protected]> Signed-off-by: Hao Yao <[email protected]>
@arter97 a few fixes here: https://github.com/hao-yao/ipu6-drivers/tree/fix-ov02c |
Yup, all done. Tested it and it works well on my laptop as well. Thanks! :) |
Nothing special than any other IPU6 setup, it differs from distros to distros so you may have to google a bit. IPU6 is generally just hard to get it right unlike traditional UVC webcams. |
Galaxy Book4 Pro uses OV02C10, and it needed some additional fixes to make it work.