Skip to content

[WIN] Fix error C7555: use of designated initializers requires at least '/std:c++20' #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whitneywhtsang merged 1 commit into from
Aug 12, 2025
Merged

[WIN] Fix error C7555: use of designated initializers requires at least '/std:c++20' #4889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 38 additions & 27 deletions lib/Dialect/TritonInstrument/Transforms/ConcurrencySanitizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,44 +280,55 @@ class ConcurrencySanitizerPass
SmallVector<MemEffects> getMemEffects(Operation *op) {
SmallVector<MemEffects> effects;
if (auto copyOp = dyn_cast<ttng::AsyncTMACopyGlobalToLocalOp>(op)) {
effects.emplace_back(
MemEffects{.buf = copyOp.getResult(),
.rw = MemEffects::RW::Write,
.barriersAndPreds = {{copyOp.getBarrier(), nullptr}},
.pred = copyOp.getPred()});
MemEffects effect;
effect.buf = copyOp.getResult();
effect.rw = MemEffects::RW::Write;
effect.barriersAndPreds = {{copyOp.getBarrier(), nullptr}};
effect.pred = copyOp.getPred();
effects.emplace_back(effect);
}
if (auto copyOp = dyn_cast<ttg::AsyncCopyGlobalToLocalOp>(op)) {
effects.emplace_back(MemEffects{.buf = copyOp.getResult(),
.rw = MemEffects::RW::Write,
.commitTracking = true});
MemEffects effect;
effect.buf = copyOp.getResult();
effect.rw = MemEffects::RW::Write;
effect.commitTracking = true;
effects.emplace_back(effect);
}
if (auto loadOp = dyn_cast<ttng::TMEMLoadOp>(op)) {
effects.emplace_back(
MemEffects{.buf = loadOp.getSrc(), .rw = MemEffects::RW::Read});
MemEffects effect;
effect.buf = loadOp.getSrc();
effect.rw = MemEffects::RW::Read;
effects.emplace_back(effect);
}
if (auto storeOp = dyn_cast<ttng::TMEMStoreOp>(op)) {
effects.emplace_back(
MemEffects{.buf = storeOp.getDst(), .rw = MemEffects::RW::Write});
MemEffects effect;
effect.buf = storeOp.getDst();
effect.rw = MemEffects::RW::Write;
effects.emplace_back(effect);
}
if (auto mmav5Op = dyn_cast<ttng::TCGen5MMAOp>(op)) {
SmallVector<std::tuple<Value, Value>> barriersAndPreds = llvm::to_vector(
llvm::zip(mmav5Op.getBarriers(), mmav5Op.getBarrierPreds()));

effects.emplace_back(MemEffects{.buf = mmav5Op.getA(),
.rw = MemEffects::RW::Read,
.barriersAndPreds = barriersAndPreds,
.pred = mmav5Op.getPred()});

effects.emplace_back(MemEffects{.buf = mmav5Op.getB(),
.rw = MemEffects::RW::Read,
.barriersAndPreds = barriersAndPreds,
.pred = mmav5Op.getPred()});

effects.emplace_back(MemEffects{.buf = mmav5Op.getAccumulator(),
.rw = MemEffects::RW::Write,
.barriersAndPreds = barriersAndPreds,
.hwPipelined = true,
.pred = mmav5Op.getPred()});
MemEffects effect;
effect.buf = mmav5Op.getA();
effect.rw = MemEffects::RW::Read;
effect.barriersAndPreds = barriersAndPreds;
effect.pred = mmav5Op.getPred();
effects.emplace_back(effect);

effect.buf = mmav5Op.getB();
effect.rw = MemEffects::RW::Read;
effect.barriersAndPreds = barriersAndPreds;
effect.pred = mmav5Op.getPred();
effects.emplace_back(effect);

effect.buf = mmav5Op.getAccumulator();
effect.rw = MemEffects::RW::Write;
effect.barriersAndPreds = barriersAndPreds;
effect.hwPipelined = true;
effect.pred = mmav5Op.getPred();
effects.emplace_back(effect);
}
return effects;
}
Expand Down