-
Notifications
You must be signed in to change notification settings - Fork 75
Update inductor_xpu_test.sh: don't add --freezing in reference mode; add new mode: inference-with-freezing
#4479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is mode "inference-no-freezing" in the script. You can set this mode via workflow input
yes, it could, but it's not so obvious. For those who don't know (like me at the beginning :) ), it will seem like a separate special mod. And since the regression issue indicates a different mode, it's quite hard to think of using this one. Can we remove it as well? |
|
I am not against it) @vlad-penkin suggested some time ago to keep both modes (inference with freezing, inference without freezing). Potentially we can make the latter default? |
Signed-off-by: Anatoly Myachev <[email protected]>
43fb9ae to
184a0a4
Compare
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, works for me. Thanks!
inductor_xpu_test.sh: don't add --freezing in reference modeinductor_xpu_test.sh: don't add --freezing in reference mode; add new mode: inference-with-freezing
There doesn't seem to be any test coverage for this. Co-authored-by: Thomas Raoux <[email protected]>
I noticed because (although I'm not sure if that's root cause):
torch-xpu-opssources in main: https://github.com/intel/torch-xpu-ops/blob/5b4d7444484576f721d2295761cf8fafa924ef36/.github/scripts/inductor_xpu_test.sh#L30in custom branch (on which they made a reproducer for us): https://github.com/intel/torch-xpu-ops/blob/6e05eb3f3cb84bceb818a9f0461da773c56ac3ef/.github/scripts/inductor_xpu_test.sh#L31