[prefetch]: Add support for prefetching load operations using a tensor of pointers#4064
Merged
[prefetch]: Add support for prefetching load operations using a tensor of pointers#4064
Conversation
…s operand. Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for prefetching load operations using a tensor of pointers with 2D prefetching intrinsics and refactors some helper functions in the conversion to be static. Key changes include:
- Converting multiple helper methods in BlockIOConversionBase to static functions.
- Updating PrefetchOpConversion to support regular pointer prefetching by adding a new rewriteRegularPointerPrefetch function and revising matchAndRewrite.
- Adjusting LoadOpToBlockIOConversion to remove the unreachable error in the tensor pointer branch.
Files not reviewed (1)
- test/TritonIntelGPU/prefetch-to-llvm.mlir: Language not supported
alexbaden
reviewed
May 1, 2025
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
etiotto
commented
May 1, 2025
| if (isTensorPointerType(ptr.getType())) { | ||
| // TODO: move the tensor pointer rewrite code here. | ||
| return failure(); | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
these changes are all NFC from here on.
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
alexbaden
approved these changes
May 2, 2025
david-hls
pushed a commit
to david-hls/intel-xpu-backend-for-triton
that referenced
this pull request
Jun 18, 2025
1. Add 3d descriptions 2. Add `acc` variable description and supported types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loads with tensor of pointers operands that have been proven to reference memory in row major (and are contained in a scf.for loop) order are now prefetched using 2D prefetching intrinsics.
Note: This PR is derived from PR #3634