[PROTON] Build Proton utilities that rely on SYCL at runtime instead of compile time && disable XPU support by default#4018
Merged
Merged
Conversation
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
changed the title
anmyachev
commented
Apr 25, 2025
Comment on lines
82
to
83
| find_library(ZE_TRACING_LIB NAMES ze_tracing_layer PATHS /usr/lib/x86_64-linux-gnu) | ||
| find_library(ZE_LOADER_LIB NAMES ze_loader PATHS /usr/lib/x86_64-linux-gnu) |
Contributor
Author
There was a problem hiding this comment.
TODO: need to move to runtime build or or disable proton build for XPU if there are no corresponding headers
pbchekin
approved these changes
Apr 25, 2025
Contributor
pbchekin
left a comment
pbchekin
left a comment
There was a problem hiding this comment.
Python code looks good, one nit.
anmyachev
commented
Apr 25, 2025
Co-authored-by: Pavel Chekin <pavel.chekin@intel.com>
Contributor
Author
|
@pbchekin do you know why DCO check failed? |
Contributor
Looks like the new check is now mandatory for our organization. Basically this check requires "Signed-off-by" statement in each commit, you can amend commits and it will pass. |
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
changed the title
Contributor
Author
|
@pbchekin could you also review the last commit? |
anmyachev
added a commit
that referenced
this pull request
Apr 28, 2025
…on14XpuptiProfilerE` (#4035) Test with pip CI (old): https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/14684390264/job/41211129850 new: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/14705967044 (passed) The problem started to appear after: #4018 This change is necessary for `import triton.profiler` to work even if the xpu profiler is not built, which happens for example in tutorial 9. --------- Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
david-hls
pushed a commit
to david-hls/intel-xpu-backend-for-triton
that referenced
this pull request
Jun 18, 2025
When processing loops we were incorrectly setting all the local def as livein. Since part of the code assumes that only livein variable can be loop carried dependency that was causing a mismatch in the logic. Change it to enforce that local def not livein cannot be loop carried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.