[FASTMATH] Allow contract by default#4015
Merged
whitneywhtsang merged 2 commits intomainfrom Apr 26, 2025
Merged
Conversation
whitneywhtsang
force-pushed
the
whitneywhtsang/fastmath
branch
from
f3f15ae to
bbe68ab
Compare
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
force-pushed
the
whitneywhtsang/fastmath
branch
from
bbe68ab to
e3276a9
Compare
chengjunlu
approved these changes
Apr 25, 2025
mfrancepillois
approved these changes
Apr 25, 2025
Contributor
|
Have you run the Inductor tests and accuracy benchmarks? |
etiotto
approved these changes
Apr 25, 2025
Contributor
Author
Inductor tests: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/14667267792 |
alexbaden
approved these changes
Apr 25, 2025
Contributor
alexbaden
left a comment
alexbaden
left a comment
There was a problem hiding this comment.
The inductor failure seems unrelated (cc @anmyachev) and enough accuracy benchmarks passed that it seems like we should be good once they finish.
Contributor
yep, unrelated. Again only cuda-device test in main branch. |
This was referenced May 19, 2025
david-hls
pushed a commit
to david-hls/intel-xpu-backend-for-triton
that referenced
this pull request
Jun 18, 2025
The TritonGPUPipeline pass has unused pass options and the TritonGPUAccelerateMatmul pass option could instead be read from the module attributes, where the data already exists. The goal is to reduce redundancy. --------- Signed-off-by: Finlay Marno <finlay.marno@codeplay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR set the fast math flag to allow contract by default.
The single most common contracted expression is FMA operations:
a * b + c → fma(a, b, c).Notes:
TRITON_DEFAULT_FP_FUSIONis an existing Triton env var, it is enabled by default.