Skip to content

[NFC][MatmulLoopPipeline] Remove unnecessary argument #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whitneywhtsang merged 1 commit into from
Apr 24, 2025
Merged

[NFC][MatmulLoopPipeline] Remove unnecessary argument #4012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions third_party/intel/lib/TritonIntelGPUTransforms/Pipeliner/MatmulLoopPipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ static ttg::DotOperandEncodingAttr allTransitiveUsesHaveDotEncoding(Value val) {
}

/// Create a prefetch operation for the given load operation.
static void createPrefetchOp(scf::ForOp &forOp, tt::LoadOp loadOp, Value ptr) {
static void createPrefetchOp(scf::ForOp &forOp, tt::LoadOp loadOp) {
OpBuilder builder(forOp);
builder.setInsertionPoint(loadOp);
auto prefetchOp = builder.create<ttgi::PrefetchOp>(
loadOp->getLoc(), ptr, loadOp.getCache(), loadOp.getEvict(),
loadOp->getLoc(), loadOp.getPtr(), loadOp.getCache(), loadOp.getEvict(),
loadOp.getIsVolatile());

// inherit attributes from the load operation
Expand All @@ -102,7 +102,7 @@ static void createPrefetchOps(scf::ForOp &forOp,
assert(!loads.empty() && "Expecting at least one load operation");
for (const LoadDotOperand &loadOperand : loads) {
tt::LoadOp loadOp = loadOperand.load;
createPrefetchOp(forOp, loadOp, loadOp.getPtr());
createPrefetchOp(forOp, loadOp);
}
}

Expand Down